starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #1771] [CLOSED] Task Offset #1561

New Issue
Closed
opened 2026-02-05 18:17:36 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:17:36 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1771
Author: @JoanFo1456
Created: 10/2/2025
Status: ❌ Closed

Base: main ← Head: fix/taskoffset

📝 Commits (4)

📊 Changes

1 file changed (+27 additions, -1 deletions)

View changed files

📝 app/Filament/Server/Resources/Schedules/RelationManagers/TasksRelationManager.php (+27 -1)

📄 Description

When you make a task for the first time, it shouldn't have an offset, seems that it broke with the update.
This pr what it does is to fix first action to not show the offset field on creation and make sure it will always be 0 when reordered or deleted a task.
I did this at 2am, so I'll be grateful on feedback.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1771 **Author:** [@JoanFo1456](https://github.com/JoanFo1456) **Created:** 10/2/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/taskoffset` --- ### 📝 Commits (4) - [`03de718`](https://github.com/pelican-dev/panel/commit/03de71897f686a7b85130f825f458572887cd0e1) Fixed reorder mess - [`cf1f7ce`](https://github.com/pelican-dev/panel/commit/cf1f7cefda7ea5b551934bd31801d5567cd4d65a) Merge branch 'pelican-dev:main' into fix/taskoffset - [`79cb51e`](https://github.com/pelican-dev/panel/commit/79cb51e8734c1ea29c19077792401a61d612b019) Phpstan and pint - [`3f62f9a`](https://github.com/pelican-dev/panel/commit/3f62f9a8e2833369712e2371af42ae25fd284213) Merge branch 'fix/taskoffset' of https://github.com/JoanFo1456/panel into fix/taskoffset ### 📊 Changes **1 file changed** (+27 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Server/Resources/Schedules/RelationManagers/TasksRelationManager.php` (+27 -1) </details> ### 📄 Description When you make a task for the first time, it shouldn't have an offset, seems that it broke with the update. This pr what it does is to fix first action to not show the offset field on creation and make sure it will always be 0 when reordered or deleted a task. I did this at 2am, so I'll be grateful on feedback. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:17:36 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1561
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?