starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #1722] [CLOSED] Make models strict and enable auto eager loading #1541

New Issue
Closed
opened 2026-02-05 18:16:59 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:16:59 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1722
Author: @Boy132
Created: 9/19/2025
Status: ❌ Closed

Base: main ← Head: boy132/eager-and-lazy

📝 Commits (6)

📊 Changes

9 files changed (+15 additions, -5 deletions)

View changed files

📝 app/Console/Commands/User/DeleteUserCommand.php (+1 -1)
📝 app/Models/EggVariable.php (+2 -0)
📝 app/Models/Server.php (+1 -0)
📝 app/Models/User.php (+0 -1)
📝 app/Notifications/AccountCreated.php (+1 -1)
📝 app/Notifications/MailTested.php (+1 -1)
📝 app/Providers/AppServiceProvider.php (+4 -0)
📝 app/Transformers/Api/Client/AllocationTransformer.php (+3 -0)
📝 tests/Integration/Services/Servers/StartupModificationServiceTest.php (+2 -1)

📄 Description

  • Prevents lazy loading, silently discarding attributes, and accessing missing attributes
  • Enables automatic eager loaded when accessing model relationshoips

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1722 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 9/19/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `boy132/eager-and-lazy` --- ### 📝 Commits (6) - [`734a111`](https://github.com/pelican-dev/panel/commit/734a1118c8073ed0294e81dbbd63d8333ff22867) make models strict and enable auto eager loading - [`0893e46`](https://github.com/pelican-dev/panel/commit/0893e460092fb43096a889931da9ea10720d6815) fix test - [`45dd239`](https://github.com/pelican-dev/panel/commit/45dd239fdc0755bb59aee4f6d07f6223c76fc97e) fix user "name" - [`5536a7b`](https://github.com/pelican-dev/panel/commit/5536a7b37707730b995f950a425a200b1e747670) fix tests v2 - [`25509f3`](https://github.com/pelican-dev/panel/commit/25509f3de6ecdbc626fa22bf77c38c34ce5b51c1) init value - [`5ea3257`](https://github.com/pelican-dev/panel/commit/5ea325700dd780d4117fe30dca4fe42fcb9a3c30) add todo ### 📊 Changes **9 files changed** (+15 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/Console/Commands/User/DeleteUserCommand.php` (+1 -1) 📝 `app/Models/EggVariable.php` (+2 -0) 📝 `app/Models/Server.php` (+1 -0) 📝 `app/Models/User.php` (+0 -1) 📝 `app/Notifications/AccountCreated.php` (+1 -1) 📝 `app/Notifications/MailTested.php` (+1 -1) 📝 `app/Providers/AppServiceProvider.php` (+4 -0) 📝 `app/Transformers/Api/Client/AllocationTransformer.php` (+3 -0) 📝 `tests/Integration/Services/Servers/StartupModificationServiceTest.php` (+2 -1) </details> ### 📄 Description - Prevents lazy loading, silently discarding attributes, and accessing missing attributes - Enables automatic eager loaded when accessing model relationshoips --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:16:59 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1541
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?