starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-07-16 04:03:50 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #1567] [CLOSED] Fixed env parser allowing ' and breaking. #1458

New Issue
Closed
opened 2026-02-05 18:14:36 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:14:36 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1567
Author: @JoanFo1456
Created: 7/30/2025
Status: ❌ Closed

Base: main ← Head: fix/env-parser

📝 Commits (2)

  • cb4a26b Made so Writer says that is invalid...
  • 9c36821 Fixed phpstan and lint...

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 app/Traits/EnvironmentWriterTrait.php (+5 -0)

📄 Description

I attempted with both " and ` seems that the only one that broke .env was '.
Let me know if you guys prefer to do it so I can stop trying...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1567 **Author:** [@JoanFo1456](https://github.com/JoanFo1456) **Created:** 7/30/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/env-parser` --- ### 📝 Commits (2) - [`cb4a26b`](https://github.com/pelican-dev/panel/commit/cb4a26b24efde733056ab4d32c69cfb1bea3c364) Made so Writer says that is invalid... - [`9c36821`](https://github.com/pelican-dev/panel/commit/9c36821eaee2e9be83efa9c8555cad913c98d53e) Fixed phpstan and lint... ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/Traits/EnvironmentWriterTrait.php` (+5 -0) </details> ### 📄 Description I attempted with both " and ` seems that the only one that broke .env was '. Let me know if you guys prefer to do it so I can stop trying... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:14:36 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1458
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?