starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #1552] [CLOSED] use condition instead of status #1451

New Issue
Closed
opened 2026-02-05 18:14:25 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:14:25 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1552
Author: @hasyirin
Created: 7/22/2025
Status: ❌ Closed

Base: main ← Head: use-condition-in-server-transformers

📝 Commits (1)

  • 00ba2fc use condition instead of status

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 app/Transformers/Api/Application/ServerTransformer.php (+1 -1)
📝 app/Transformers/Api/Client/ServerTransformer.php (+1 -1)

📄 Description

Server status is null most of the time, I think it should use server condition instead.
Honestly, I think it's better if we deprecate status field and add in a condition field instead, but other deprecated comments in the files are saying to use status field.. so...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1552 **Author:** [@hasyirin](https://github.com/hasyirin) **Created:** 7/22/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `use-condition-in-server-transformers` --- ### 📝 Commits (1) - [`00ba2fc`](https://github.com/pelican-dev/panel/commit/00ba2fcf027d23dc047de90303f795cc6cdf1b22) use condition instead of status ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/Transformers/Api/Application/ServerTransformer.php` (+1 -1) 📝 `app/Transformers/Api/Client/ServerTransformer.php` (+1 -1) </details> ### 📄 Description Server status is null most of the time, I think it should use server condition instead. Honestly, I think it's better if we deprecate status field and add in a condition field instead, but other deprecated comments in the files are saying to use status field.. so... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:14:25 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1451
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?