starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-07-16 04:03:50 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #1507] [CLOSED] Adds same-network check for port allocations. #1422

New Issue
Closed
opened 2026-02-05 18:13:31 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:13:31 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1507
Author: @mkaulfers
Created: 7/10/2025
Status: ❌ Closed

Base: main ← Head: main

📄 Description

NOTE!

I have some hesitation if this should be merged in or not. It's entirely possible that the exception would be thrown if two nodes are on the same "Subnet" but on different networks.

Adds a new validation check for same network check on nodes and port allocations. If two separate nodes share the same subnet, it will throw an invalid port exception whenever a duplicate is detected.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1507 **Author:** [@mkaulfers](https://github.com/mkaulfers) **Created:** 7/10/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📄 Description # NOTE! I have some hesitation if this should be merged in or not. It's entirely possible that the exception would be thrown if two nodes are on the same "Subnet" but on different networks. --- Adds a new validation check for same network check on nodes and port allocations. If two separate nodes share the same subnet, it will throw an invalid port exception whenever a duplicate is detected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:13:31 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1422
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?