starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #1461] [MERGED] Fix: Search for tags in correct variable #1405

New Issue
Closed
opened 2026-02-05 18:12:53 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:12:53 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1461
Author: @wbvanderbroek
Created: 6/22/2025
Status: ✅ Merged
Merged: 6/26/2025
Merged by: @lancepioch

Base: main ← Head: fix/server-tags

📝 Commits (1)

  • d12f80a Fix: Search for tags in correct variable

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 app/Services/Servers/ServerCreationService.php (+1 -1)

📄 Description

Previously creating a server through the api on a specific node wouldn't work with something like this in the payload:

"deploy" => [
"dedicated_ip" => false,
"tags" => ["yournodetag"],
"port_range" => []
],
Because the tag would be completely erased by the validator. And would only be stored in the deployment variable.
This will fix that by using the deployment variable instead of the data variable

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1461 **Author:** [@wbvanderbroek](https://github.com/wbvanderbroek) **Created:** 6/22/2025 **Status:** ✅ Merged **Merged:** 6/26/2025 **Merged by:** [@lancepioch](https://github.com/lancepioch) **Base:** `main` ← **Head:** `fix/server-tags` --- ### 📝 Commits (1) - [`d12f80a`](https://github.com/pelican-dev/panel/commit/d12f80a1921ccdbf071a4bccdbe46f8b35798242) Fix: Search for tags in correct variable ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Services/Servers/ServerCreationService.php` (+1 -1) </details> ### 📄 Description Previously creating a server through the api on a specific node wouldn't work with something like this in the payload: "deploy" => [ "dedicated_ip" => false, "tags" => ["yournodetag"], "port_range" => [] ], Because the tag would be completely erased by the validator. And would only be stored in the deployment variable. This will fix that by using the deployment variable instead of the data variable --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:12:53 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1405
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?