starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-07-16 04:03:50 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #1431] [MERGED] Replace $allocation->toString() with $allocation->address #1383

New Issue
Closed
opened 2026-02-05 18:12:15 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:12:15 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1431
Author: @rmartinoscar
Created: 6/4/2025
Status: ✅ Merged
Merged: 6/4/2025
Merged by: @rmartinoscar

Base: main ← Head: chore/removeUselessFunction

📝 Commits (1)

  • eb324eb Replace $allocation->toString() with $allocation->address

📊 Changes

4 files changed (+6 additions, -11 deletions)

View changed files

📝 app/Filament/Server/Resources/AllocationResource.php (+1 -1)
📝 app/Filament/Server/Resources/AllocationResource/Pages/ListAllocations.php (+1 -1)
📝 app/Http/Controllers/Api/Client/Servers/NetworkAllocationController.php (+4 -4)
📝 app/Models/Allocation.php (+0 -5)

📄 Description

address is already a string
0ba497a2eb/app/Models/Allocation.php (L26)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1431 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 6/4/2025 **Status:** ✅ Merged **Merged:** 6/4/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `chore/removeUselessFunction` --- ### 📝 Commits (1) - [`eb324eb`](https://github.com/pelican-dev/panel/commit/eb324eb893179b4196d53a31452fbbc35ae1b80a) Replace `$allocation->toString()` with `$allocation->address` ### 📊 Changes **4 files changed** (+6 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Server/Resources/AllocationResource.php` (+1 -1) 📝 `app/Filament/Server/Resources/AllocationResource/Pages/ListAllocations.php` (+1 -1) 📝 `app/Http/Controllers/Api/Client/Servers/NetworkAllocationController.php` (+4 -4) 📝 `app/Models/Allocation.php` (+0 -5) </details> ### 📄 Description `address` is already a string https://github.com/pelican-dev/panel/blob/0ba497a2eb6e77ece0847b908e698602a78cabf5/app/Models/Allocation.php#L26 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:12:15 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1383
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?