starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #1253] [MERGED] Fix storage graph not rendering correctly #1281

New Issue
Closed
opened 2026-02-05 18:09:03 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:09:03 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1253
Author: @LetterN
Created: 4/13/2025
Status: ✅ Merged
Merged: 4/15/2025
Merged by: @rmartinoscar

Base: main ← Head: patch-1

📝 Commits (3)

  • d3c64ed use round instead of Number::format
  • 64cb0a3 remove unused
  • 58955a8 also replace Number::format in cpu & memory charts

📊 Changes

3 files changed (+4 additions, -5 deletions)

View changed files

📝 app/Filament/Admin/Resources/NodeResource/Widgets/NodeCpuChart.php (+1 -1)
📝 app/Filament/Admin/Resources/NodeResource/Widgets/NodeMemoryChart.php (+1 -1)
📝 app/Filament/Admin/Resources/NodeResource/Widgets/NodeStorageChart.php (+2 -3)

📄 Description

Use round instead of Number::format since that adds a comma once it reaches 1k which breaks chartjs render.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1253 **Author:** [@LetterN](https://github.com/LetterN) **Created:** 4/13/2025 **Status:** ✅ Merged **Merged:** 4/15/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (3) - [`d3c64ed`](https://github.com/pelican-dev/panel/commit/d3c64ed6b9fdae09525c9d98539e67ec6f8bc9f8) use round instead of `Number::format` - [`64cb0a3`](https://github.com/pelican-dev/panel/commit/64cb0a34ecd99d1e84389d75335f4499570ce235) remove unused - [`58955a8`](https://github.com/pelican-dev/panel/commit/58955a88ba7e6aee92ad96f4f8a4aee24003529f) also replace `Number::format` in cpu & memory charts ### 📊 Changes **3 files changed** (+4 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Admin/Resources/NodeResource/Widgets/NodeCpuChart.php` (+1 -1) 📝 `app/Filament/Admin/Resources/NodeResource/Widgets/NodeMemoryChart.php` (+1 -1) 📝 `app/Filament/Admin/Resources/NodeResource/Widgets/NodeStorageChart.php` (+2 -3) </details> ### 📄 Description Use round instead of `Number::format` since that adds a comma once it reaches 1k which breaks chartjs render. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:09:03 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1281
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?