starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #1196] [MERGED] Add unique foreign keys for EggVariable #1237

New Issue
Closed
opened 2026-02-05 18:07:46 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:07:46 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1196
Author: @rmartinoscar
Created: 4/1/2025
Status: ✅ Merged
Merged: 4/3/2025
Merged by: @rmartinoscar

Base: main ← Head: issue/545

📝 Commits (2)

  • 8753d69 Fix test egg_variable order
  • fa3b813 Add EggVariable unique foreign key for env_variable & name

📊 Changes

6 files changed (+54 additions, -21 deletions)

View changed files

➕ database/migrations/2025_04_01_033956_egg_variable_unique_foreign_key.php (+30 -0)
📝 tests/Integration/Api/Client/Server/Startup/GetStartupAndVariablesTest.php (+1 -1)
📝 tests/Integration/Api/Client/Server/Startup/UpdateStartupVariableTest.php (+3 -3)
📝 tests/Integration/Services/Servers/ServerCreationServiceTest.php (+2 -2)
📝 tests/Integration/Services/Servers/StartupModificationServiceTest.php (+8 -8)
📝 tests/Integration/Services/Servers/VariableValidatorServiceTest.php (+10 -7)

📄 Description

Supersedes https://github.com/pelican-dev/panel/pull/549
Closes #545 (api side since https://github.com/pelican-dev/panel/pull/902 already makes them unique in the frontend)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1196 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 4/1/2025 **Status:** ✅ Merged **Merged:** 4/3/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `issue/545` --- ### 📝 Commits (2) - [`8753d69`](https://github.com/pelican-dev/panel/commit/8753d698814799f7f4a636854194a72f181941ee) Fix test egg_variable order - [`fa3b813`](https://github.com/pelican-dev/panel/commit/fa3b813a40125c28a0befae671fe4adce7f82e55) Add `EggVariable` unique foreign key for `env_variable` & `name` ### 📊 Changes **6 files changed** (+54 additions, -21 deletions) <details> <summary>View changed files</summary> ➕ `database/migrations/2025_04_01_033956_egg_variable_unique_foreign_key.php` (+30 -0) 📝 `tests/Integration/Api/Client/Server/Startup/GetStartupAndVariablesTest.php` (+1 -1) 📝 `tests/Integration/Api/Client/Server/Startup/UpdateStartupVariableTest.php` (+3 -3) 📝 `tests/Integration/Services/Servers/ServerCreationServiceTest.php` (+2 -2) 📝 `tests/Integration/Services/Servers/StartupModificationServiceTest.php` (+8 -8) 📝 `tests/Integration/Services/Servers/VariableValidatorServiceTest.php` (+10 -7) </details> ### 📄 Description Supersedes https://github.com/pelican-dev/panel/pull/549 Closes #545 (api side since https://github.com/pelican-dev/panel/pull/902 already makes them unique in the frontend) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:07:46 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1237
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?