starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #1181] [MERGED] Must use Closure since MenuItem does not leverage Concerns #1231

New Issue
Closed
opened 2026-02-05 18:07:31 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:07:31 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1181
Author: @rmartinoscar
Created: 3/28/2025
Status: ✅ Merged
Merged: 3/28/2025
Merged by: @rmartinoscar

Base: main ← Head: fix/MenuItemTranslation

📝 Commits (2)

  • 59e9c5d Must use Closure since MenuItem does not leverage Concerns
  • 5b48269 Translate Profile in ServerPanelProvider

📊 Changes

2 files changed (+7 additions, -3 deletions)

View changed files

📝 app/Providers/Filament/AdminPanelProvider.php (+4 -2)
📝 app/Providers/Filament/ServerPanelProvider.php (+3 -1)

📄 Description

https://github.com/filamentphp/filament/issues/13342
I hate cache it should have been catched before https://github.com/pelican-dev/panel/pull/1178

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1181 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 3/28/2025 **Status:** ✅ Merged **Merged:** 3/28/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `fix/MenuItemTranslation` --- ### 📝 Commits (2) - [`59e9c5d`](https://github.com/pelican-dev/panel/commit/59e9c5d380f9f42e9efe868ad2469137841bc3e6) Must use `Closure` since `MenuItem` does not leverage Concerns - [`5b48269`](https://github.com/pelican-dev/panel/commit/5b482698b0559767d87b41ecd7dcefc462209de7) Translate `Profile` in `ServerPanelProvider` ### 📊 Changes **2 files changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/Providers/Filament/AdminPanelProvider.php` (+4 -2) 📝 `app/Providers/Filament/ServerPanelProvider.php` (+3 -1) </details> ### 📄 Description https://github.com/filamentphp/filament/issues/13342 I hate cache it should have been catched before https://github.com/pelican-dev/panel/pull/1178 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:07:31 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1231
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?