starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #999] [MERGED] Fix Health ScheduleCheck #1103

New Issue
Closed
opened 2026-02-05 18:03:56 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:03:56 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/999
Author: @rmartinoscar
Created: 2/12/2025
Status: ✅ Merged
Merged: 2/12/2025
Merged by: @rmartinoscar

Base: main ← Head: fix/HealthScheduleCheck

📝 Commits (2)

  • 09d3f74 Use ScheduleCheck instead of a blank Check
  • 26d3da2 Change Check to BaseCheck

📊 Changes

1 file changed (+2 additions, -39 deletions)

View changed files

📝 app/Checks/ScheduleCheck.php (+2 -39)

📄 Description

a6963ad802/app/Console/Kernel.php (L59) Will always fail cause it checks if ScheduleCheck is registered
image

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/999 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 2/12/2025 **Status:** ✅ Merged **Merged:** 2/12/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `fix/HealthScheduleCheck` --- ### 📝 Commits (2) - [`09d3f74`](https://github.com/pelican-dev/panel/commit/09d3f74ccfbff76806714772af46c13bc6e33a3f) Use ScheduleCheck instead of a blank Check - [`26d3da2`](https://github.com/pelican-dev/panel/commit/26d3da2fa9009ac5a0ee0a6622688319b8c784c9) Change Check to BaseCheck ### 📊 Changes **1 file changed** (+2 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `app/Checks/ScheduleCheck.php` (+2 -39) </details> ### 📄 Description https://github.com/pelican-dev/panel/blob/a6963ad8026a7d7f31fc6fc6423e8eeba4022de8/app/Console/Kernel.php#L59 Will always fail cause [it checks if ScheduleCheck is registered](https://github.com/spatie/laravel-health/blob/main/src/Commands/ScheduleCheckHeartbeatCommand.php#L17-L25) ![image](https://github.com/user-attachments/assets/f71bc0da-3b0c-46ed-b80e-cd90bbbb7879) ![image](https://github.com/user-attachments/assets/8212dbf7-ced7-456f-9bee-618ac528e5b5) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:03:56 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1103
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?