[PR #949] [MERGED] Fix schedules #1073

Closed
opened 2026-02-05 18:02:56 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/949
Author: @rmartinoscar
Created: 1/26/2025
Status: Merged
Merged: 1/27/2025
Merged by: @rmartinoscar

Base: mainHead: fix/Schedules


📝 Commits (4)

📊 Changes

2 files changed (+13 additions, -11 deletions)

View changed files

📝 app/Filament/Server/Resources/ScheduleResource.php (+2 -2)
📝 app/Filament/Server/Resources/ScheduleResource/RelationManagers/TasksRelationManager.php (+11 -9)

📄 Description

  • fix every_x_months resulting in invalid cron
  • move Sunday to last entry
  • set default action otherwise its still power action but payload is a TextInput instead of desired Select
  • set payload to empty string if it doesn't exist on edit action

Closes #947


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/949 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 1/26/2025 **Status:** ✅ Merged **Merged:** 1/27/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `fix/Schedules` --- ### 📝 Commits (4) - [`1449df7`](https://github.com/pelican-dev/panel/commit/1449df76fb8ddcd913a3b781dc46d7366c70fcfc) Fix schedules - [`cd5cf57`](https://github.com/pelican-dev/panel/commit/cd5cf57141b1e02430f6ab491f8b5bb8430d317e) Pint - [`4d7b683`](https://github.com/pelican-dev/panel/commit/4d7b683bac5c1e16dccc23da9babc075df2e946a) Only explode when payload isnt a power action - [`d01aaa1`](https://github.com/pelican-dev/panel/commit/d01aaa18857aad5ab5023249f37b2a3cb5664d49) Run only on first day of the month ### 📊 Changes **2 files changed** (+13 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Server/Resources/ScheduleResource.php` (+2 -2) 📝 `app/Filament/Server/Resources/ScheduleResource/RelationManagers/TasksRelationManager.php` (+11 -9) </details> ### 📄 Description - [x] fix every_x_months resulting in invalid cron - [x] move Sunday to last entry - [x] set default action otherwise its still power action but payload is a TextInput instead of desired Select - [x] set payload to empty string if it doesn't exist on edit action Closes #947 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:02:56 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1073