starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-02-05 08:42:50 +03:00
Code Issues Packages Projects Releases Wiki Activity
Page: Contributor Policies
Pages
Building from Source Contributing to Jellyfin Contributor Policies Expected Errors Feature Requests Home Issue Guidelines Jellyfin Coding Style Jellyfin Debian Repository Prebuilt Packages Riot Matrix Rooms Social Media Translations Web archive of Emby documentation
Clone
3
Contributor Policies
Joshua M. Boniface edited this page 2019-01-02 13:20:49 -05:00

This page describes general procedures for the contributors with write access to the repositories. All contributors should seek to adhere to these policies to ensure consistency in the repository.

  1. Contributors should set code ownership CODEOWNERS files wherever they consider themselves subject-matter expects, to assist in the review process.

  2. PRs to dev should have at least one review by a code owner before being merged. If a section does not have a codeowner, any contributor may review it. More reviews are always better, especially for large PRs or if there are no defined codeowners.

  3. PRs to dev should be merged as "Create a merge commit" to ensure the relevant PR is always referenced.

  4. PRs to master should only come from dev as a whole, and in the form of a release PR. This PR should be merged as "Create a merge commit" to preserve release history. The PR body should contain a full list of accepted dev PRs. The only exception to this procedure should be emergency PRs which address an extremely time-sensitive issue and where the usual process would be excessively long.