starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4236] [MERGED] Fix some warnings #9970

New Issue
Closed
opened 2026-02-07 06:11:45 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:11:45 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4236
Author: @ConfusedPolarBear
Created: 9/29/2020
Status: ✅ Merged
Merged: 9/29/2020
Merged by: @Bond-009

Base: master ← Head: warnings1

📝 Commits (1)

  • 53d5f64 Fix SA1513, SA1514, SA1507, and SA1508

📊 Changes

47 files changed (+74 additions, -33 deletions)

View changed files

📝 Emby.Server.Implementations/Data/SqliteItemRepository.cs (+0 -3)
📝 Emby.Server.Implementations/Dto/DtoService.cs (+0 -1)
📝 Emby.Server.Implementations/EntryPoints/UserDataChangeNotifier.cs (+0 -1)
📝 Emby.Server.Implementations/LiveTv/Listings/SchedulesDirect.cs (+0 -8)
📝 Emby.Server.Implementations/LiveTv/LiveTvManager.cs (+1 -0)
📝 Emby.Server.Implementations/Updates/InstallationManager.cs (+1 -0)
📝 MediaBrowser.Controller/Channels/InternalChannelFeatures.cs (+2 -0)
📝 MediaBrowser.Controller/Entities/Audio/Audio.cs (+0 -1)
📝 MediaBrowser.Controller/Entities/BaseItem.cs (+2 -0)
📝 MediaBrowser.Controller/Entities/Folder.cs (+0 -1)
📝 MediaBrowser.Controller/Entities/IHasMediaSources.cs (+0 -2)
📝 MediaBrowser.Controller/Entities/Photo.cs (+0 -1)
📝 MediaBrowser.Controller/Entities/TV/Series.cs (+0 -1)
📝 MediaBrowser.Controller/Entities/UserViewBuilder.cs (+0 -1)
📝 MediaBrowser.Controller/IO/FileData.cs (+0 -1)
📝 MediaBrowser.Controller/Library/ILibraryManager.cs (+2 -0)
📝 MediaBrowser.Controller/Library/IMediaSourceManager.cs (+2 -0)
📝 MediaBrowser.Controller/Library/ItemResolveArgs.cs (+1 -0)
📝 MediaBrowser.Controller/LiveTv/ILiveTvManager.cs (+1 -0)
📝 MediaBrowser.Controller/LiveTv/ITunerHost.cs (+0 -1)

...and 27 more files

📄 Description

As part of #2149, removes all occurrences of:

  • SA1514: Element documentation header should be preceded by blank line (53 warnings)
  • SA1513: Closing brace should be followed by blank line (21 warnings)
  • SA1507: Code should not contain multiple blank lines in a row (18 warnings)
  • SA1508: A closing brace should not be preceded by a blank line (8 warnings)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4236 **Author:** [@ConfusedPolarBear](https://github.com/ConfusedPolarBear) **Created:** 9/29/2020 **Status:** ✅ Merged **Merged:** 9/29/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `warnings1` --- ### 📝 Commits (1) - [`53d5f64`](https://github.com/jellyfin/jellyfin/commit/53d5f64e037c13c295d82fcb98b91ef2de8fc842) Fix SA1513, SA1514, SA1507, and SA1508 ### 📊 Changes **47 files changed** (+74 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Data/SqliteItemRepository.cs` (+0 -3) 📝 `Emby.Server.Implementations/Dto/DtoService.cs` (+0 -1) 📝 `Emby.Server.Implementations/EntryPoints/UserDataChangeNotifier.cs` (+0 -1) 📝 `Emby.Server.Implementations/LiveTv/Listings/SchedulesDirect.cs` (+0 -8) 📝 `Emby.Server.Implementations/LiveTv/LiveTvManager.cs` (+1 -0) 📝 `Emby.Server.Implementations/Updates/InstallationManager.cs` (+1 -0) 📝 `MediaBrowser.Controller/Channels/InternalChannelFeatures.cs` (+2 -0) 📝 `MediaBrowser.Controller/Entities/Audio/Audio.cs` (+0 -1) 📝 `MediaBrowser.Controller/Entities/BaseItem.cs` (+2 -0) 📝 `MediaBrowser.Controller/Entities/Folder.cs` (+0 -1) 📝 `MediaBrowser.Controller/Entities/IHasMediaSources.cs` (+0 -2) 📝 `MediaBrowser.Controller/Entities/Photo.cs` (+0 -1) 📝 `MediaBrowser.Controller/Entities/TV/Series.cs` (+0 -1) 📝 `MediaBrowser.Controller/Entities/UserViewBuilder.cs` (+0 -1) 📝 `MediaBrowser.Controller/IO/FileData.cs` (+0 -1) 📝 `MediaBrowser.Controller/Library/ILibraryManager.cs` (+2 -0) 📝 `MediaBrowser.Controller/Library/IMediaSourceManager.cs` (+2 -0) 📝 `MediaBrowser.Controller/Library/ItemResolveArgs.cs` (+1 -0) 📝 `MediaBrowser.Controller/LiveTv/ILiveTvManager.cs` (+1 -0) 📝 `MediaBrowser.Controller/LiveTv/ITunerHost.cs` (+0 -1) _...and 27 more files_ </details> ### 📄 Description As part of #2149, removes all occurrences of: * SA1514: Element documentation header should be preceded by blank line (53 warnings) * SA1513: Closing brace should be followed by blank line (21 warnings) * SA1507: Code should not contain multiple blank lines in a row (18 warnings) * SA1508: A closing brace should not be preceded by a blank line (8 warnings) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:11:45 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9970
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?