starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4234] [CLOSED] Revert part of #3007 to fix LocalAddress in /system/info/public #9967

New Issue
Closed
opened 2026-02-07 06:11:43 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:11:43 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4234
Author: @nielsvanvelzen
Created: 9/28/2020
Status: ❌ Closed

Base: master ← Head: windows-vm-localaddress

📝 Commits (1)

  • 11828c9 Revert part of #3007 to fix LocalAddress in /system/info/public

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 Emby.Server.Implementations/Networking/NetworkManager.cs (+7 -1)

📄 Description

Changes

  • Added back a check that was removed in #3007

The /system/info/public endpoint reported "http://172.29.80.1:8096" (which is the address of a virtual ethernet adapter from Hyper-V on my machine) as my LocalAddress and after adding this bit of code back it was "http://192.168.1.10:8096" again.

I'm not sure if this is a proper fix but I'll let you guys decide that.

This should fix a bunch of chromecast issues that started in 10.6.0 for hyper-v users on Windows. I could only find chromecast issue that seemed relevant.

Issues

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4234 **Author:** [@nielsvanvelzen](https://github.com/nielsvanvelzen) **Created:** 9/28/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `windows-vm-localaddress` --- ### 📝 Commits (1) - [`11828c9`](https://github.com/jellyfin/jellyfin/commit/11828c944adb04abe77e952901d495ed3c342903) Revert part of #3007 to fix LocalAddress in /system/info/public ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Networking/NetworkManager.cs` (+7 -1) </details> ### 📄 Description **Changes** - Added back a check that was removed in #3007 The /system/info/public endpoint reported "http://172.29.80.1:8096" (which is the address of a virtual ethernet adapter from Hyper-V on my machine) as my LocalAddress and after adding this bit of code back it was "http://192.168.1.10:8096" again. I'm not sure if this is a proper fix but I'll let you guys decide that. This should fix a bunch of chromecast issues that started in 10.6.0 for hyper-v users on Windows. I could only find chromecast issue that seemed relevant. **Issues** - Me using my desktop as Jellyfin server - Maybe #3712 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:11:43 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9967
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?