starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4217] [MERGED] Properly handle null structs in json #9955

New Issue
Closed
opened 2026-02-07 06:11:27 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:11:27 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4217
Author: @crobibero
Created: 9/27/2020
Status: ✅ Merged
Merged: 10/2/2020
Merged by: @Bond-009

Base: master ← Head: json-nullable-struct-converter

📝 Commits (1)

  • ac790cd Properly handle null structs in json

📊 Changes

3 files changed (+48 additions, -25 deletions)

View changed files

📝 MediaBrowser.Common/Json/Converters/JsonNullableStructConverter.cs (+20 -19)
➕ MediaBrowser.Common/Json/Converters/JsonNullableStructConverterFactory.cs (+27 -0)
📝 MediaBrowser.Common/Json/JsonDefaults.cs (+1 -6)

📄 Description

Use factory instead of manually adding
Call JsonSerializer instead of passing serializer through constructor

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4217 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 9/27/2020 **Status:** ✅ Merged **Merged:** 10/2/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `json-nullable-struct-converter` --- ### 📝 Commits (1) - [`ac790cd`](https://github.com/jellyfin/jellyfin/commit/ac790cd77b81a8235f6d1faf9512c85c96fcd088) Properly handle null structs in json ### 📊 Changes **3 files changed** (+48 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Common/Json/Converters/JsonNullableStructConverter.cs` (+20 -19) ➕ `MediaBrowser.Common/Json/Converters/JsonNullableStructConverterFactory.cs` (+27 -0) 📝 `MediaBrowser.Common/Json/JsonDefaults.cs` (+1 -6) </details> ### 📄 Description Use factory instead of manually adding Call JsonSerializer instead of passing serializer through constructor --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:11:27 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9955
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?