[PR #4202] [MERGED] Migrate the TMDb providers to the TMDbLib library #9939

Closed
opened 2026-02-07 06:11:10 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4202
Author: @cvium
Created: 9/24/2020
Status: Merged
Merged: 10/5/2020
Merged by: @joshuaboniface

Base: masterHead: tmdblib_migration


📝 Commits (10+)

  • e9524f8 Migrate the TMDb providers to the TMDbLib library
  • 08e1f15 Cleanup in TmdbMovieProvider
  • 34d2716 Remove TmdbSettingsResult which came back in the rebase
  • f8c4f7c Fix inverted boolean statement
  • 3df2a95 Cleanup in TmdbUtils
  • f4d49ef Add keywords as tags
  • 9adbf4e Add keywords as tags to series + cleanup
  • c0f4c90 Apply suggestions from code review
  • e0f21af Fix build
  • d7cabb2 Add image languages

📊 Changes

74 files changed (+1590 additions, -3857 deletions)

View changed files

📝 Emby.Server.Implementations/ApplicationHost.cs (+2 -0)
MediaBrowser.Model/Extensions/EnumerableExtensions.cs (+46 -0)
📝 MediaBrowser.Providers/MediaBrowser.Providers.csproj (+1 -0)
📝 MediaBrowser.Providers/Plugins/Tmdb/BoxSets/TmdbBoxSetImageProvider.cs (+46 -97)
📝 MediaBrowser.Providers/Plugins/Tmdb/BoxSets/TmdbBoxSetProvider.cs (+51 -203)
MediaBrowser.Providers/Plugins/Tmdb/Models/Collections/CollectionImages.cs (+0 -14)
MediaBrowser.Providers/Plugins/Tmdb/Models/Collections/CollectionResult.cs (+0 -23)
MediaBrowser.Providers/Plugins/Tmdb/Models/Collections/Part.cs (+0 -17)
MediaBrowser.Providers/Plugins/Tmdb/Models/General/Backdrop.cs (+0 -21)
MediaBrowser.Providers/Plugins/Tmdb/Models/General/Crew.cs (+0 -19)
MediaBrowser.Providers/Plugins/Tmdb/Models/General/ExternalIds.cs (+0 -17)
MediaBrowser.Providers/Plugins/Tmdb/Models/General/Genre.cs (+0 -11)
MediaBrowser.Providers/Plugins/Tmdb/Models/General/Images.cs (+0 -13)
MediaBrowser.Providers/Plugins/Tmdb/Models/General/Keyword.cs (+0 -11)
MediaBrowser.Providers/Plugins/Tmdb/Models/General/Keywords.cs (+0 -11)
MediaBrowser.Providers/Plugins/Tmdb/Models/General/Poster.cs (+0 -21)
MediaBrowser.Providers/Plugins/Tmdb/Models/General/Profile.cs (+0 -17)
MediaBrowser.Providers/Plugins/Tmdb/Models/General/Still.cs (+0 -23)
MediaBrowser.Providers/Plugins/Tmdb/Models/General/StillImages.cs (+0 -11)
MediaBrowser.Providers/Plugins/Tmdb/Models/General/Video.cs (+0 -23)

...and 54 more files

📄 Description

Changes
Moved the TMDb providers to TMDbLib. Less code to maintain, hopefully.

NOTE: Semi-blocked by https://github.com/LordMike/TMDbLib/pull/344.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4202 **Author:** [@cvium](https://github.com/cvium) **Created:** 9/24/2020 **Status:** ✅ Merged **Merged:** 10/5/2020 **Merged by:** [@joshuaboniface](https://github.com/joshuaboniface) **Base:** `master` ← **Head:** `tmdblib_migration` --- ### 📝 Commits (10+) - [`e9524f8`](https://github.com/jellyfin/jellyfin/commit/e9524f89d63894ea9af62cd1b61ddd89cb8b9e82) Migrate the TMDb providers to the TMDbLib library - [`08e1f15`](https://github.com/jellyfin/jellyfin/commit/08e1f15add2bcc328c56191ff18c392263880bb6) Cleanup in TmdbMovieProvider - [`34d2716`](https://github.com/jellyfin/jellyfin/commit/34d2716ce81087cc6a7315f90210e9816d0948c2) Remove TmdbSettingsResult which came back in the rebase - [`f8c4f7c`](https://github.com/jellyfin/jellyfin/commit/f8c4f7c63e3adb98dc1ad30aa01c3dd3d5c1e76c) Fix inverted boolean statement - [`3df2a95`](https://github.com/jellyfin/jellyfin/commit/3df2a95cac1e34f3392abbf239c9c7eb137e88cd) Cleanup in TmdbUtils - [`f4d49ef`](https://github.com/jellyfin/jellyfin/commit/f4d49eff9bc209743270b104cb20a3ebd4f95d4e) Add keywords as tags - [`9adbf4e`](https://github.com/jellyfin/jellyfin/commit/9adbf4e9d8e52ed42619b4413d1eaccaa752b37d) Add keywords as tags to series + cleanup - [`c0f4c90`](https://github.com/jellyfin/jellyfin/commit/c0f4c90d57ef32f00bdbdd4e5fa767322cd07905) Apply suggestions from code review - [`e0f21af`](https://github.com/jellyfin/jellyfin/commit/e0f21afa6285e6c4153ebc39d3524f8f7d19096c) Fix build - [`d7cabb2`](https://github.com/jellyfin/jellyfin/commit/d7cabb2e4ed601a09579b5e280d02115e476c902) Add image languages ### 📊 Changes **74 files changed** (+1590 additions, -3857 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+2 -0) ➕ `MediaBrowser.Model/Extensions/EnumerableExtensions.cs` (+46 -0) 📝 `MediaBrowser.Providers/MediaBrowser.Providers.csproj` (+1 -0) 📝 `MediaBrowser.Providers/Plugins/Tmdb/BoxSets/TmdbBoxSetImageProvider.cs` (+46 -97) 📝 `MediaBrowser.Providers/Plugins/Tmdb/BoxSets/TmdbBoxSetProvider.cs` (+51 -203) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/Collections/CollectionImages.cs` (+0 -14) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/Collections/CollectionResult.cs` (+0 -23) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/Collections/Part.cs` (+0 -17) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/General/Backdrop.cs` (+0 -21) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/General/Crew.cs` (+0 -19) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/General/ExternalIds.cs` (+0 -17) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/General/Genre.cs` (+0 -11) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/General/Images.cs` (+0 -13) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/General/Keyword.cs` (+0 -11) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/General/Keywords.cs` (+0 -11) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/General/Poster.cs` (+0 -21) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/General/Profile.cs` (+0 -17) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/General/Still.cs` (+0 -23) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/General/StillImages.cs` (+0 -11) ➖ `MediaBrowser.Providers/Plugins/Tmdb/Models/General/Video.cs` (+0 -23) _...and 54 more files_ </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** Moved the TMDb providers to TMDbLib. Less code to maintain, hopefully. **NOTE**: Semi-blocked by https://github.com/LordMike/TMDbLib/pull/344. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:11:10 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9939