starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4109] [CLOSED] Project: Network 7 - Static and commented implementation of the code as recommended by the IDE. #9885

New Issue
Closed
opened 2026-02-07 06:10:11 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:10:11 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4109
Author: @BaronGreenback
Created: 9/9/2020
Status: ❌ Closed

Base: master ← Head: Dlna_simplification2

📝 Commits (6)

  • 763867c Static and commented implimention of the code as recommended by the IDE.
  • 4ae9f69 Add files via upload
  • 0d64c6e Add files via upload
  • 90b3dd2 Add files via upload
  • 5dc928c Update ControlHandler.cs
  • c678380 Update MediaReceiverRegistrarXmlBuilder.cs

📊 Changes

18 files changed (+1230 additions, -382 deletions)

View changed files

📝 Emby.Dlna/ConnectionManager/ConnectionManagerService.cs (+11 -3)
📝 Emby.Dlna/ConnectionManager/ConnectionManagerXmlBuilder.cs (+79 -68)
📝 Emby.Dlna/ConnectionManager/ControlHandler.cs (+13 -2)
📝 Emby.Dlna/ConnectionManager/ServiceActionListBuilder.cs (+32 -7)
📝 Emby.Dlna/ContentDirectory/ContentDirectoryService.cs (+28 -3)
📝 Emby.Dlna/ContentDirectory/ContentDirectoryXmlBuilder.cs (+120 -111)
📝 Emby.Dlna/ContentDirectory/ControlHandler.cs (+430 -77)
📝 Emby.Dlna/ContentDirectory/ServerItem.cs (+13 -2)
📝 Emby.Dlna/ContentDirectory/ServiceActionListBuilder.cs (+44 -7)
📝 Emby.Dlna/ContentDirectory/StubType.cs (+3 -0)
📝 Emby.Dlna/Didl/DidlBuilder.cs (+247 -28)
📝 Emby.Dlna/Didl/Filter.cs (+15 -2)
📝 Emby.Dlna/Didl/StringWriterWithEncoding.cs (+42 -1)
📝 Emby.Dlna/MediaReceiverRegistrar/ControlHandler.cs (+16 -2)
📝 Emby.Dlna/MediaReceiverRegistrar/MediaReceiverRegistrarService.cs (+10 -3)
📝 Emby.Dlna/MediaReceiverRegistrar/MediaReceiverRegistrarXmlBuilder.cs (+66 -55)
📝 Emby.Dlna/MediaReceiverRegistrar/ServiceActionListBuilder.cs (+40 -7)
📝 Emby.Dlna/Service/ServiceXmlBuilder.cs (+21 -4)

📄 Description

Commented all methods.

Changed to static where recommended.

Simplified using.

Nothing else changed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4109 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 9/9/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `Dlna_simplification2` --- ### 📝 Commits (6) - [`763867c`](https://github.com/jellyfin/jellyfin/commit/763867cdb6ef5b30684ec565adcf67ea92c71af8) Static and commented implimention of the code as recommended by the IDE. - [`4ae9f69`](https://github.com/jellyfin/jellyfin/commit/4ae9f699e57bf726b599c005dded0236f765f7c4) Add files via upload - [`0d64c6e`](https://github.com/jellyfin/jellyfin/commit/0d64c6e40147335d816645b5364e6707e63f2262) Add files via upload - [`90b3dd2`](https://github.com/jellyfin/jellyfin/commit/90b3dd2f6caf2abe8abe860264161ed300bc382c) Add files via upload - [`5dc928c`](https://github.com/jellyfin/jellyfin/commit/5dc928cb24627b211890aaeb17767e2b23a9f4ff) Update ControlHandler.cs - [`c678380`](https://github.com/jellyfin/jellyfin/commit/c67838073cdc058e913617ad8e10422a3855cdc3) Update MediaReceiverRegistrarXmlBuilder.cs ### 📊 Changes **18 files changed** (+1230 additions, -382 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/ConnectionManager/ConnectionManagerService.cs` (+11 -3) 📝 `Emby.Dlna/ConnectionManager/ConnectionManagerXmlBuilder.cs` (+79 -68) 📝 `Emby.Dlna/ConnectionManager/ControlHandler.cs` (+13 -2) 📝 `Emby.Dlna/ConnectionManager/ServiceActionListBuilder.cs` (+32 -7) 📝 `Emby.Dlna/ContentDirectory/ContentDirectoryService.cs` (+28 -3) 📝 `Emby.Dlna/ContentDirectory/ContentDirectoryXmlBuilder.cs` (+120 -111) 📝 `Emby.Dlna/ContentDirectory/ControlHandler.cs` (+430 -77) 📝 `Emby.Dlna/ContentDirectory/ServerItem.cs` (+13 -2) 📝 `Emby.Dlna/ContentDirectory/ServiceActionListBuilder.cs` (+44 -7) 📝 `Emby.Dlna/ContentDirectory/StubType.cs` (+3 -0) 📝 `Emby.Dlna/Didl/DidlBuilder.cs` (+247 -28) 📝 `Emby.Dlna/Didl/Filter.cs` (+15 -2) 📝 `Emby.Dlna/Didl/StringWriterWithEncoding.cs` (+42 -1) 📝 `Emby.Dlna/MediaReceiverRegistrar/ControlHandler.cs` (+16 -2) 📝 `Emby.Dlna/MediaReceiverRegistrar/MediaReceiverRegistrarService.cs` (+10 -3) 📝 `Emby.Dlna/MediaReceiverRegistrar/MediaReceiverRegistrarXmlBuilder.cs` (+66 -55) 📝 `Emby.Dlna/MediaReceiverRegistrar/ServiceActionListBuilder.cs` (+40 -7) 📝 `Emby.Dlna/Service/ServiceXmlBuilder.cs` (+21 -4) </details> ### 📄 Description Commented all methods. Changed to static where recommended. Simplified using. Nothing else changed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:10:11 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9885
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?