[PR #4085] [CLOSED] Project: Network Code Review 1 - Structures #9868

Closed
opened 2026-02-07 06:09:54 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4085
Author: @BaronGreenback
Created: 9/8/2020
Status: Closed

Base: masterHead: NetReview1


📝 Commits (4)

📊 Changes

3 files changed (+1181 additions, -0 deletions)

View changed files

Jellyfin.Networking/Structures/IPHost.cs (+437 -0)
Jellyfin.Networking/Structures/IPNetAddress.cs (+355 -0)
Jellyfin.Networking/Structures/IPObject.cs (+389 -0)

📄 Description

These are the helper classes for the networkManager.

IPHost and IPNetAddress both inherit, and share properties with IPObject.

Both items can deal with IPv4/IPv6.

The main differences are:-

IPHosts are items that are items that can have multiple ip addresses if resolved (they don't have to be).

IPNetAddress are network addresses (IPAddess + subnet masks)

I've tried to include helpful comments throughout.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4085 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 9/8/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `NetReview1` --- ### 📝 Commits (4) - [`d4004bc`](https://github.com/jellyfin/jellyfin/commit/d4004bcaf585a146e433d23d7781a2fb55b33cb0) Merge pull request #62 from jellyfin/master - [`a3a7901`](https://github.com/jellyfin/jellyfin/commit/a3a790150d08403aa8c00b6d63a2dca791c84728) Create IPHost.cs - [`2303e57`](https://github.com/jellyfin/jellyfin/commit/2303e571b3f0494c1da22d4db22be0382dfa1826) Add files via upload - [`04c8735`](https://github.com/jellyfin/jellyfin/commit/04c8735c50f35ab9ee6130ebb99f840ff7863cb5) Delete NetCollection.cs ### 📊 Changes **3 files changed** (+1181 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `Jellyfin.Networking/Structures/IPHost.cs` (+437 -0) ➕ `Jellyfin.Networking/Structures/IPNetAddress.cs` (+355 -0) ➕ `Jellyfin.Networking/Structures/IPObject.cs` (+389 -0) </details> ### 📄 Description These are the helper classes for the networkManager. IPHost and IPNetAddress both inherit, and share properties with IPObject. Both items can deal with IPv4/IPv6. The main differences are:- IPHosts are items that are items that can have multiple ip addresses if resolved (they don't have to be). IPNetAddress are network addresses (IPAddess + subnet masks) I've tried to include helpful comments throughout. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:09:54 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9868