starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4083] [CLOSED] Unstable: Null Pointer fix: Api application builder extensions #9865

New Issue
Closed
opened 2026-02-07 06:09:50 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:09:50 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4083
Author: @BaronGreenback
Created: 9/7/2020
Status: ❌ Closed

Base: master ← Head: ApiApplicationBuilderExtensions

📝 Commits (2)

  • d4004bc Merge pull request #62 from jellyfin/master
  • 8f8c8f8 Update ApiApplicationBuilderExtensions.cs

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 Jellyfin.Server/Extensions/ApiApplicationBuilderExtensions.cs (+2 -2)

📄 Description

If BaseUrl is null - the code failed.

I'm also assuming that apiDocBaseUrl will change at some point - so i've left that code as is;

var baseUrl = serverConfigurationManager.Configuration.BaseUrl;
var apiDocBaseUrl = serverConfigurationManager.Configuration.BaseUrl;

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4083 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 9/7/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `ApiApplicationBuilderExtensions` --- ### 📝 Commits (2) - [`d4004bc`](https://github.com/jellyfin/jellyfin/commit/d4004bcaf585a146e433d23d7781a2fb55b33cb0) Merge pull request #62 from jellyfin/master - [`8f8c8f8`](https://github.com/jellyfin/jellyfin/commit/8f8c8f85de450124e20ac03771486e24aba06560) Update ApiApplicationBuilderExtensions.cs ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Server/Extensions/ApiApplicationBuilderExtensions.cs` (+2 -2) </details> ### 📄 Description If BaseUrl is null - the code failed. I'm also assuming that apiDocBaseUrl will change at some point - so i've left that code as is; ``` var baseUrl = serverConfigurationManager.Configuration.BaseUrl; var apiDocBaseUrl = serverConfigurationManager.Configuration.BaseUrl; ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:09:50 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9865
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?