starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4069] [MERGED] Make all FromRoute required #9854

New Issue
Closed
opened 2026-02-07 06:09:39 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:09:39 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4069
Author: @crobibero
Created: 9/6/2020
Status: ✅ Merged
Merged: 9/6/2020
Merged by: @Bond-009

Base: master ← Head: api-route-required

📝 Commits (3)

📊 Changes

40 files changed (+262 additions, -240 deletions)

View changed files

📝 Jellyfin.Api/Controllers/AlbumsController.cs (+3 -2)
📝 Jellyfin.Api/Controllers/ArtistsController.cs (+2 -1)
📝 Jellyfin.Api/Controllers/AudioController.cs (+3 -2)
📝 Jellyfin.Api/Controllers/ChannelsController.cs (+3 -2)
📝 Jellyfin.Api/Controllers/CollectionController.cs (+2 -2)
📝 Jellyfin.Api/Controllers/ConfigurationController.cs (+2 -2)
📝 Jellyfin.Api/Controllers/DisplayPreferencesController.cs (+2 -2)
📝 Jellyfin.Api/Controllers/DlnaController.cs (+4 -3)
📝 Jellyfin.Api/Controllers/DlnaServerController.cs (+10 -9)
📝 Jellyfin.Api/Controllers/DynamicHlsController.cs (+16 -16)
📝 Jellyfin.Api/Controllers/GenresController.cs (+2 -1)
📝 Jellyfin.Api/Controllers/HlsSegmentController.cs (+7 -6)
📝 Jellyfin.Api/Controllers/ImageController.cs (+79 -78)
📝 Jellyfin.Api/Controllers/InstantMixController.cs (+6 -6)
📝 Jellyfin.Api/Controllers/ItemLookupController.cs (+2 -2)
📝 Jellyfin.Api/Controllers/ItemRefreshController.cs (+2 -1)
📝 Jellyfin.Api/Controllers/ItemUpdateController.cs (+3 -3)
📝 Jellyfin.Api/Controllers/ItemsController.cs (+3 -2)
📝 Jellyfin.Api/Controllers/LibraryController.cs (+8 -8)
📝 Jellyfin.Api/Controllers/LiveTvController.cs (+14 -13)

...and 20 more files

📄 Description

Swashbuckle needs the [Required] attribute to automatically add Nullable: false to the generated spec.
All route parameters are always required

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4069 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 9/6/2020 **Status:** ✅ Merged **Merged:** 9/6/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `api-route-required` --- ### 📝 Commits (3) - [`59d47ec`](https://github.com/jellyfin/jellyfin/commit/59d47ec3f52d8592f6a2aac405ee214cfda10081) Make all FromRoute required - [`b641089`](https://github.com/jellyfin/jellyfin/commit/b64108923aebd0f3e5a960462ad4cb2dbd74b6cc) Add missing references - [`29fc882`](https://github.com/jellyfin/jellyfin/commit/29fc882037162b8c7a79557556be9d535e94779f) merge all attributes ### 📊 Changes **40 files changed** (+262 additions, -240 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/AlbumsController.cs` (+3 -2) 📝 `Jellyfin.Api/Controllers/ArtistsController.cs` (+2 -1) 📝 `Jellyfin.Api/Controllers/AudioController.cs` (+3 -2) 📝 `Jellyfin.Api/Controllers/ChannelsController.cs` (+3 -2) 📝 `Jellyfin.Api/Controllers/CollectionController.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/ConfigurationController.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/DisplayPreferencesController.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/DlnaController.cs` (+4 -3) 📝 `Jellyfin.Api/Controllers/DlnaServerController.cs` (+10 -9) 📝 `Jellyfin.Api/Controllers/DynamicHlsController.cs` (+16 -16) 📝 `Jellyfin.Api/Controllers/GenresController.cs` (+2 -1) 📝 `Jellyfin.Api/Controllers/HlsSegmentController.cs` (+7 -6) 📝 `Jellyfin.Api/Controllers/ImageController.cs` (+79 -78) 📝 `Jellyfin.Api/Controllers/InstantMixController.cs` (+6 -6) 📝 `Jellyfin.Api/Controllers/ItemLookupController.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/ItemRefreshController.cs` (+2 -1) 📝 `Jellyfin.Api/Controllers/ItemUpdateController.cs` (+3 -3) 📝 `Jellyfin.Api/Controllers/ItemsController.cs` (+3 -2) 📝 `Jellyfin.Api/Controllers/LibraryController.cs` (+8 -8) 📝 `Jellyfin.Api/Controllers/LiveTvController.cs` (+14 -13) _...and 20 more files_ </details> ### 📄 Description Swashbuckle needs the `[Required]` attribute to automatically add `Nullable: false` to the generated spec. All route parameters are always required --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:09:39 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9854
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?