starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4037] [MERGED] Set openapi schema type to file where possible #9836

New Issue
Closed
opened 2026-02-07 06:09:20 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:09:20 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4037
Author: @crobibero
Created: 9/2/2020
Status: ✅ Merged
Merged: 9/9/2020
Merged by: @Bond-009

Base: master ← Head: api-stream-return

📝 Commits (10+)

  • 2f33bee Set openapi schema type to file where possible
  • c989529 Fix ValidatePath response code
  • c473645 Set openapi schema type to file where possible
  • ec2a5e4 Simplify file returns
  • a698dab Specify image file return for GetItemImage2
  • 932c4d2 Clean api return types
  • 9c6d011 Add missing image return types
  • 1be84e8 Merge remote-tracking branch 'upstream/master' into api-stream-return
  • eb2dcbd Merge remote-tracking branch 'upstream/master' into api-stream-return
  • a26063f fix merge

📊 Changes

27 files changed (+247 additions, -32 deletions)

View changed files

➕ Jellyfin.Api/Attributes/ProducesAudioFileAttribute.cs (+18 -0)
➕ Jellyfin.Api/Attributes/ProducesFileAttribute.cs (+28 -0)
➕ Jellyfin.Api/Attributes/ProducesImageFileAttribute.cs (+18 -0)
➕ Jellyfin.Api/Attributes/ProducesPlaylistFileAttribute.cs (+18 -0)
➕ Jellyfin.Api/Attributes/ProducesVideoFileAttribute.cs (+18 -0)
📝 Jellyfin.Api/Controllers/AudioController.cs (+2 -0)
📝 Jellyfin.Api/Controllers/ConfigurationController.cs (+3 -0)
📝 Jellyfin.Api/Controllers/DashboardController.cs (+3 -0)
📝 Jellyfin.Api/Controllers/DlnaServerController.cs (+11 -4)
📝 Jellyfin.Api/Controllers/DynamicHlsController.cs (+7 -0)
📝 Jellyfin.Api/Controllers/EnvironmentController.cs (+3 -3)
📝 Jellyfin.Api/Controllers/HlsSegmentController.cs (+4 -0)
📝 Jellyfin.Api/Controllers/ImageByNameController.cs (+10 -6)
📝 Jellyfin.Api/Controllers/ImageController.cs (+10 -2)
📝 Jellyfin.Api/Controllers/ItemLookupController.cs (+8 -6)
📝 Jellyfin.Api/Controllers/LibraryController.cs (+4 -2)
📝 Jellyfin.Api/Controllers/LiveTvController.cs (+4 -0)
📝 Jellyfin.Api/Controllers/MediaInfoController.cs (+2 -0)
📝 Jellyfin.Api/Controllers/RemoteImageController.cs (+3 -1)
📝 Jellyfin.Api/Controllers/SubtitleController.cs (+5 -2)

...and 7 more files

📄 Description

Swashbuckle doesn't support generating Schema Type: File, so have to create a filter that will edit the schema.
AspNetCore doesn't support [Produces()] with a wildcard.

#4029

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4037 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 9/2/2020 **Status:** ✅ Merged **Merged:** 9/9/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `api-stream-return` --- ### 📝 Commits (10+) - [`2f33bee`](https://github.com/jellyfin/jellyfin/commit/2f33bee2a94f7175050f83d568f8bd65a01a86f8) Set openapi schema type to file where possible - [`c989529`](https://github.com/jellyfin/jellyfin/commit/c98952937e463c842fc28f8595caddb511319fc8) Fix ValidatePath response code - [`c473645`](https://github.com/jellyfin/jellyfin/commit/c473645f9dc6c46f5148c7a27ec612a4c62502b8) Set openapi schema type to file where possible - [`ec2a5e4`](https://github.com/jellyfin/jellyfin/commit/ec2a5e4fb03ace8182b80ef81151bda6021051c4) Simplify file returns - [`a698dab`](https://github.com/jellyfin/jellyfin/commit/a698dab66fb8cb17ca12f03c4a271cbe15b7fac1) Specify image file return for GetItemImage2 - [`932c4d2`](https://github.com/jellyfin/jellyfin/commit/932c4d25a40148a8fe0994c81937907ed9496195) Clean api return types - [`9c6d011`](https://github.com/jellyfin/jellyfin/commit/9c6d0117b50fb593cb11767ee391758504cf1348) Add missing image return types - [`1be84e8`](https://github.com/jellyfin/jellyfin/commit/1be84e8873ed05b548663f9625c95bc9bed302e6) Merge remote-tracking branch 'upstream/master' into api-stream-return - [`eb2dcbd`](https://github.com/jellyfin/jellyfin/commit/eb2dcbddc07c1f8d440bdb21490f9ba53eda0463) Merge remote-tracking branch 'upstream/master' into api-stream-return - [`a26063f`](https://github.com/jellyfin/jellyfin/commit/a26063f775f49b2a8968ea9b9ac9391fb38db24c) fix merge ### 📊 Changes **27 files changed** (+247 additions, -32 deletions) <details> <summary>View changed files</summary> ➕ `Jellyfin.Api/Attributes/ProducesAudioFileAttribute.cs` (+18 -0) ➕ `Jellyfin.Api/Attributes/ProducesFileAttribute.cs` (+28 -0) ➕ `Jellyfin.Api/Attributes/ProducesImageFileAttribute.cs` (+18 -0) ➕ `Jellyfin.Api/Attributes/ProducesPlaylistFileAttribute.cs` (+18 -0) ➕ `Jellyfin.Api/Attributes/ProducesVideoFileAttribute.cs` (+18 -0) 📝 `Jellyfin.Api/Controllers/AudioController.cs` (+2 -0) 📝 `Jellyfin.Api/Controllers/ConfigurationController.cs` (+3 -0) 📝 `Jellyfin.Api/Controllers/DashboardController.cs` (+3 -0) 📝 `Jellyfin.Api/Controllers/DlnaServerController.cs` (+11 -4) 📝 `Jellyfin.Api/Controllers/DynamicHlsController.cs` (+7 -0) 📝 `Jellyfin.Api/Controllers/EnvironmentController.cs` (+3 -3) 📝 `Jellyfin.Api/Controllers/HlsSegmentController.cs` (+4 -0) 📝 `Jellyfin.Api/Controllers/ImageByNameController.cs` (+10 -6) 📝 `Jellyfin.Api/Controllers/ImageController.cs` (+10 -2) 📝 `Jellyfin.Api/Controllers/ItemLookupController.cs` (+8 -6) 📝 `Jellyfin.Api/Controllers/LibraryController.cs` (+4 -2) 📝 `Jellyfin.Api/Controllers/LiveTvController.cs` (+4 -0) 📝 `Jellyfin.Api/Controllers/MediaInfoController.cs` (+2 -0) 📝 `Jellyfin.Api/Controllers/RemoteImageController.cs` (+3 -1) 📝 `Jellyfin.Api/Controllers/SubtitleController.cs` (+5 -2) _...and 7 more files_ </details> ### 📄 Description Swashbuckle doesn't support generating `Schema Type: File`, so have to create a filter that will edit the schema. AspNetCore doesn't support `[Produces()]` with a wildcard. #4029 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:09:20 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9836
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?