starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4033] [MERGED] Readd nullable number converters #9830

New Issue
Closed
opened 2026-02-07 06:09:15 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:09:15 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4033
Author: @crobibero
Created: 9/1/2020
Status: ✅ Merged
Merged: 9/1/2020
Merged by: @Bond-009

Base: master ← Head: empty-string-nullable-number

📝 Commits (5)

  • 9b2359a readd nullable number converters
  • 1f2d73a Only handle empty string or null case
  • eb400f7 Fallback to base jsonconverter
  • 471e760 remove unused declaration
  • 9ddf550 Simplify json converters

📊 Changes

2 files changed (+50 additions, -0 deletions)

View changed files

➕ MediaBrowser.Common/Json/Converters/JsonNullableStructConverter.cs (+44 -0)
📝 MediaBrowser.Common/Json/JsonDefaults.cs (+6 -0)

📄 Description

Sometimes clients send empty string representing a nullable number.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4033 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 9/1/2020 **Status:** ✅ Merged **Merged:** 9/1/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `empty-string-nullable-number` --- ### 📝 Commits (5) - [`9b2359a`](https://github.com/jellyfin/jellyfin/commit/9b2359a4534df1b9700bdac8888e720bb0acda1d) readd nullable number converters - [`1f2d73a`](https://github.com/jellyfin/jellyfin/commit/1f2d73af8e986b945c53a4a8bc1be1124216589e) Only handle empty string or null case - [`eb400f7`](https://github.com/jellyfin/jellyfin/commit/eb400f72928c9a87362c7d763be4627a7f9cd5cb) Fallback to base jsonconverter - [`471e760`](https://github.com/jellyfin/jellyfin/commit/471e7600572356b51c6e1b49f97410c5e4363a2e) remove unused declaration - [`9ddf550`](https://github.com/jellyfin/jellyfin/commit/9ddf550b43b3dcaa1129e369242bd664632bff03) Simplify json converters ### 📊 Changes **2 files changed** (+50 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `MediaBrowser.Common/Json/Converters/JsonNullableStructConverter.cs` (+44 -0) 📝 `MediaBrowser.Common/Json/JsonDefaults.cs` (+6 -0) </details> ### 📄 Description Sometimes clients send empty string representing a nullable number. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:09:16 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9830
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?