starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #3895] [MERGED] Remove IHttpClient from Jellyfin.Api #9751

New Issue
Closed
opened 2026-02-07 06:07:49 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:07:49 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3895
Author: @crobibero
Created: 8/14/2020
Status: ✅ Merged
Merged: 8/17/2020
Merged by: @Bond-009

Base: master ← Head: httpclient

📝 Commits (3)

  • 97fd11c Remove httpclient from Jellyfin.Api
  • 8ddcd12 Remove all using for HttpClient
  • 8da646e Dispose httpclient response

📊 Changes

4 files changed (+22 additions, -31 deletions)

View changed files

📝 Jellyfin.Api/Controllers/AudioController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/LiveTvController.cs (+10 -11)
📝 Jellyfin.Api/Controllers/RemoteImageController.cs (+10 -18)
📝 Jellyfin.Api/Controllers/VideosController.cs (+1 -1)

📄 Description

IHttpClient -> IHttpClientFactory

unsure if using var client = _httpClientFactory.CreateClient(); is correct with new IHttpClientFactory.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3895 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 8/14/2020 **Status:** ✅ Merged **Merged:** 8/17/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `httpclient` --- ### 📝 Commits (3) - [`97fd11c`](https://github.com/jellyfin/jellyfin/commit/97fd11c9a43c136badf2d35945bbe50ffaaa6a85) Remove httpclient from Jellyfin.Api - [`8ddcd12`](https://github.com/jellyfin/jellyfin/commit/8ddcd12348da48c8a07a7f897c014974995af6d9) Remove all using for HttpClient - [`8da646e`](https://github.com/jellyfin/jellyfin/commit/8da646e12b6122b3a73830eb9cbf3e39033d8ba3) Dispose httpclient response ### 📊 Changes **4 files changed** (+22 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/AudioController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/LiveTvController.cs` (+10 -11) 📝 `Jellyfin.Api/Controllers/RemoteImageController.cs` (+10 -18) 📝 `Jellyfin.Api/Controllers/VideosController.cs` (+1 -1) </details> ### 📄 Description IHttpClient -> IHttpClientFactory unsure if `using var client = _httpClientFactory.CreateClient();` is correct with new IHttpClientFactory. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:07:49 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9751
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?