starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #3861] [MERGED] API Fixes #9733

New Issue
Closed
opened 2026-02-07 06:07:31 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:07:31 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3861
Author: @crobibero
Created: 8/10/2020
Status: ✅ Merged
Merged: 8/19/2020
Merged by: @anthonylavado

Base: master ← Head: fixes

📝 Commits (10+)

  • 7b864e3 parameter isn't actually required
  • 460c3dd convert dependent controller functions to di helper class
  • c5e9cf1 Use proper IHttpContextAccessor
  • 2e3ef18 fix route typo
  • 2f853b9 fix datetime parsing
  • 4b87bbf fix route
  • b0532c5 add proper converter for legacy datetime
  • 3ba1f4c add proper converter for legacy datetime
  • bb08e25 userid isn't actually required
  • eb7ab31 add support for GetActivityLogs

📊 Changes

18 files changed (+1593 additions, -1275 deletions)

View changed files

📝 Emby.Server.Implementations/ApplicationHost.cs (+3 -0)
📝 Jellyfin.Api/Controllers/AudioController.cs (+6 -161)
📝 Jellyfin.Api/Controllers/DevicesController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/DynamicHlsController.cs (+8 -440)
📝 Jellyfin.Api/Controllers/HlsSegmentController.cs (+2 -2)
📝 Jellyfin.Api/Controllers/LiveTvController.cs (+3 -3)
📝 Jellyfin.Api/Controllers/MediaInfoController.cs (+38 -500)
📝 Jellyfin.Api/Controllers/NotificationsController.cs (+0 -1)
📝 Jellyfin.Api/Controllers/PlaystateController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/SessionController.cs (+2 -2)
📝 Jellyfin.Api/Controllers/UniversalAudioController.cs (+141 -140)
📝 Jellyfin.Api/Controllers/VideosController.cs (+3 -4)
➕ Jellyfin.Api/Helpers/AudioHelper.cs (+195 -0)
➕ Jellyfin.Api/Helpers/DynamicHlsHelper.cs (+550 -0)
📝 Jellyfin.Api/Helpers/FileStreamResponseHelpers.cs (+17 -19)
➕ Jellyfin.Api/Helpers/MediaInfoHelper.cs (+573 -0)
➕ Jellyfin.Api/TypeConverters/DateTimeTypeConverter.cs (+44 -0)
📝 Jellyfin.Server/Startup.cs (+6 -1)

📄 Description

95% copy & paste from controller to helper class.

Required attribute here was causing validation error responses to web, guess the parameter wasn't actually required.
7b864e3a3c

Also snuck in some api route fixes.

Fixes #3885

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3861 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 8/10/2020 **Status:** ✅ Merged **Merged:** 8/19/2020 **Merged by:** [@anthonylavado](https://github.com/anthonylavado) **Base:** `master` ← **Head:** `fixes` --- ### 📝 Commits (10+) - [`7b864e3`](https://github.com/jellyfin/jellyfin/commit/7b864e3a3c286c9502b6ef3ff1d13754e796706a) parameter isn't actually required - [`460c3dd`](https://github.com/jellyfin/jellyfin/commit/460c3dd35166c9a48db83db62a3f0a8742956408) convert dependent controller functions to di helper class - [`c5e9cf1`](https://github.com/jellyfin/jellyfin/commit/c5e9cf15f6476d96eadc1d32e38687c3a5a98a17) Use proper IHttpContextAccessor - [`2e3ef18`](https://github.com/jellyfin/jellyfin/commit/2e3ef18a11f73c8365573ffb86c62cb4bd82a74d) fix route typo - [`2f853b9`](https://github.com/jellyfin/jellyfin/commit/2f853b902a801da16c819cd745087bbed23701b6) fix datetime parsing - [`4b87bbf`](https://github.com/jellyfin/jellyfin/commit/4b87bbf53d61e5855c69e8d566d466e7c849c9e8) fix route - [`b0532c5`](https://github.com/jellyfin/jellyfin/commit/b0532c549a6ba8c743a807aed7f6b42b63aee708) add proper converter for legacy datetime - [`3ba1f4c`](https://github.com/jellyfin/jellyfin/commit/3ba1f4c9019155daf7db6865016eaa8914f54ee6) add proper converter for legacy datetime - [`bb08e25`](https://github.com/jellyfin/jellyfin/commit/bb08e25f86c4542fac49e7b6184edd5065fb970b) userid isn't actually required - [`eb7ab31`](https://github.com/jellyfin/jellyfin/commit/eb7ab31b5ab8045aff41f014bb61dfd67b4ec557) add support for GetActivityLogs ### 📊 Changes **18 files changed** (+1593 additions, -1275 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+3 -0) 📝 `Jellyfin.Api/Controllers/AudioController.cs` (+6 -161) 📝 `Jellyfin.Api/Controllers/DevicesController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/DynamicHlsController.cs` (+8 -440) 📝 `Jellyfin.Api/Controllers/HlsSegmentController.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/LiveTvController.cs` (+3 -3) 📝 `Jellyfin.Api/Controllers/MediaInfoController.cs` (+38 -500) 📝 `Jellyfin.Api/Controllers/NotificationsController.cs` (+0 -1) 📝 `Jellyfin.Api/Controllers/PlaystateController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/SessionController.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/UniversalAudioController.cs` (+141 -140) 📝 `Jellyfin.Api/Controllers/VideosController.cs` (+3 -4) ➕ `Jellyfin.Api/Helpers/AudioHelper.cs` (+195 -0) ➕ `Jellyfin.Api/Helpers/DynamicHlsHelper.cs` (+550 -0) 📝 `Jellyfin.Api/Helpers/FileStreamResponseHelpers.cs` (+17 -19) ➕ `Jellyfin.Api/Helpers/MediaInfoHelper.cs` (+573 -0) ➕ `Jellyfin.Api/TypeConverters/DateTimeTypeConverter.cs` (+44 -0) 📝 `Jellyfin.Server/Startup.cs` (+6 -1) </details> ### 📄 Description 95% copy & paste from controller to helper class. Required attribute here was causing validation error responses to web, guess the parameter wasn't actually required. https://github.com/jellyfin/jellyfin/pull/3861/commits/7b864e3a3c286c9502b6ef3ff1d13754e796706a Also snuck in some api route fixes. Fixes #3885 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:07:31 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9733
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?