starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #3853] [CLOSED] Fix warnings in Rssdp #9731

New Issue
Closed
opened 2026-02-07 06:07:27 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:07:27 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3853
Author: @daullmer
Created: 8/8/2020
Status: ❌ Closed

Base: master ← Head: rssdp-warnings

📝 Commits (2)

  • 7dc0bdf Fix warnings in Rssdp
  • 5fb5641 Move field initialization and dispose correctly

📊 Changes

22 files changed (+461 additions, -561 deletions)

View changed files

📝 RSSDP/DeviceAvailableEventArgs.cs (+12 -12)
📝 RSSDP/DeviceEventArgs.cs (+5 -5)
📝 RSSDP/DeviceUnavailableEventArgs.cs (+10 -10)
📝 RSSDP/DiscoveredSsdpDevice.cs (+9 -16)
📝 RSSDP/Infrastructure/DisposableManagedObjectBase.cs (+15 -14)
📝 RSSDP/Infrastructure/HttpParserBase.cs (+22 -23)
📝 RSSDP/Infrastructure/HttpRequestParser.cs (+3 -2)
📝 RSSDP/Infrastructure/HttpResponseParser.cs (+3 -3)
📝 RSSDP/Infrastructure/IEnumerableExtensions.cs (+1 -2)
📝 RSSDP/Infrastructure/ISsdpCommunicationsServer.cs (+9 -8)
📝 RSSDP/Infrastructure/ISsdpDeviceLocator.cs (+5 -5)
📝 RSSDP/Infrastructure/ISsdpDevicePublisher.cs (+7 -7)
📝 RSSDP/Infrastructure/RequestReceivedEventArgs.cs (+11 -12)
📝 RSSDP/Infrastructure/ResponseReceivedEventArgs.cs (+11 -12)
📝 RSSDP/Infrastructure/SsdpCommunicationsServer.cs (+63 -66)
📝 RSSDP/Infrastructure/SsdpConstants.cs (+7 -2)
📝 RSSDP/Infrastructure/SsdpDeviceLocator.cs (+63 -131)
📝 RSSDP/Infrastructure/SsdpDevicePublisher.cs (+111 -129)
📝 RSSDP/RSSDP.csproj (+12 -0)
📝 RSSDP/SsdpDevice.cs (+71 -74)

...and 2 more files

📄 Description

Part of #2149

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3853 **Author:** [@daullmer](https://github.com/daullmer) **Created:** 8/8/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `rssdp-warnings` --- ### 📝 Commits (2) - [`7dc0bdf`](https://github.com/jellyfin/jellyfin/commit/7dc0bdf70d0047d6f87667f19a6645888b55a452) Fix warnings in Rssdp - [`5fb5641`](https://github.com/jellyfin/jellyfin/commit/5fb564190b5b05a99a0333b03fb3f7c7e69ba04c) Move field initialization and dispose correctly ### 📊 Changes **22 files changed** (+461 additions, -561 deletions) <details> <summary>View changed files</summary> 📝 `RSSDP/DeviceAvailableEventArgs.cs` (+12 -12) 📝 `RSSDP/DeviceEventArgs.cs` (+5 -5) 📝 `RSSDP/DeviceUnavailableEventArgs.cs` (+10 -10) 📝 `RSSDP/DiscoveredSsdpDevice.cs` (+9 -16) 📝 `RSSDP/Infrastructure/DisposableManagedObjectBase.cs` (+15 -14) 📝 `RSSDP/Infrastructure/HttpParserBase.cs` (+22 -23) 📝 `RSSDP/Infrastructure/HttpRequestParser.cs` (+3 -2) 📝 `RSSDP/Infrastructure/HttpResponseParser.cs` (+3 -3) 📝 `RSSDP/Infrastructure/IEnumerableExtensions.cs` (+1 -2) 📝 `RSSDP/Infrastructure/ISsdpCommunicationsServer.cs` (+9 -8) 📝 `RSSDP/Infrastructure/ISsdpDeviceLocator.cs` (+5 -5) 📝 `RSSDP/Infrastructure/ISsdpDevicePublisher.cs` (+7 -7) 📝 `RSSDP/Infrastructure/RequestReceivedEventArgs.cs` (+11 -12) 📝 `RSSDP/Infrastructure/ResponseReceivedEventArgs.cs` (+11 -12) 📝 `RSSDP/Infrastructure/SsdpCommunicationsServer.cs` (+63 -66) 📝 `RSSDP/Infrastructure/SsdpConstants.cs` (+7 -2) 📝 `RSSDP/Infrastructure/SsdpDeviceLocator.cs` (+63 -131) 📝 `RSSDP/Infrastructure/SsdpDevicePublisher.cs` (+111 -129) 📝 `RSSDP/RSSDP.csproj` (+12 -0) 📝 `RSSDP/SsdpDevice.cs` (+71 -74) _...and 2 more files_ </details> ### 📄 Description Part of #2149 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:07:27 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9731
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?