starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #3699] Fix embedded subtitles #9657

New Issue
Closed
opened 2026-02-07 06:06:11 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:06:11 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/3699

State: closed
Merged: Yes

Changes

Fixes regression introduced by #3521

Issues

[2020-07-25 09:34:12.790 +00:00] [ERR] [71] Emby.Server.Implementations.HttpServer.HttpListenerHost: Error processing request. URL: "http://10.79.0.125:8096/Videos/b886d888-2eac-d1cb-732d-dfde121feb39/b886d8882eacd1cb732ddfde121feb39/Subtitles/2/0/Stream.ass"
System.NullReferenceException: Object reference not set to an instance of an object.
   at Emby.Server.Implementations.Library.MediaSourceManager.GetPathProtocol(String path)
   at MediaBrowser.MediaEncoding.Subtitles.SubtitleEncoder.GetSubtitleStream(MediaSourceInfo mediaSource, MediaStream subtitleStream, CancellationToken cancellationToken)
   at MediaBrowser.MediaEncoding.Subtitles.SubtitleEncoder.MediaBrowser.Controller.MediaEncoding.ISubtitleEncoder.GetSubtitles(BaseItem item, String mediaSourceId, Int32 subtitleStreamIndex, String outputFormat, Int64 startTimeTicks, Int64 endTimeTicks, Boolean preserveOriginalTimestamps, CancellationToken cancellationToken)
   at MediaBrowser.Api.Subtitles.SubtitleService.Get(GetSubtitle request)
   at Emby.Server.Implementations.Services.ServiceExecGeneral.GetTaskResult(Task task)
   at Emby.Server.Implementations.Services.ServiceHandler.ProcessRequestAsync(HttpListenerHost httpHost, IRequest httpReq, HttpResponse httpRes, ILogger logger, CancellationToken cancellationToken)
   at Emby.Server.Implementations.HttpServer.HttpListenerHost.RequestHandler(IHttpRequest httpReq, String urlString, String host, String localPath, CancellationToken cancellationToken)
[2020-07-25 09:34:12.856 +00:00] [DBG] [71] Emby.Server.Implementations.HttpServer.HttpListenerHost: Sending HTTP Response 500 in response to "http://10.79.0.125:8096/Videos/b886d888-2eac-d1cb-732d-dfde121feb39/b886d8882eacd1cb732ddfde121feb39/Subtitles/2/0/Stream.ass"
**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/3699 **State:** closed **Merged:** Yes --- <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> Fixes regression introduced by #3521 **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> ```csharp [2020-07-25 09:34:12.790 +00:00] [ERR] [71] Emby.Server.Implementations.HttpServer.HttpListenerHost: Error processing request. URL: "http://10.79.0.125:8096/Videos/b886d888-2eac-d1cb-732d-dfde121feb39/b886d8882eacd1cb732ddfde121feb39/Subtitles/2/0/Stream.ass" System.NullReferenceException: Object reference not set to an instance of an object. at Emby.Server.Implementations.Library.MediaSourceManager.GetPathProtocol(String path) at MediaBrowser.MediaEncoding.Subtitles.SubtitleEncoder.GetSubtitleStream(MediaSourceInfo mediaSource, MediaStream subtitleStream, CancellationToken cancellationToken) at MediaBrowser.MediaEncoding.Subtitles.SubtitleEncoder.MediaBrowser.Controller.MediaEncoding.ISubtitleEncoder.GetSubtitles(BaseItem item, String mediaSourceId, Int32 subtitleStreamIndex, String outputFormat, Int64 startTimeTicks, Int64 endTimeTicks, Boolean preserveOriginalTimestamps, CancellationToken cancellationToken) at MediaBrowser.Api.Subtitles.SubtitleService.Get(GetSubtitle request) at Emby.Server.Implementations.Services.ServiceExecGeneral.GetTaskResult(Task task) at Emby.Server.Implementations.Services.ServiceHandler.ProcessRequestAsync(HttpListenerHost httpHost, IRequest httpReq, HttpResponse httpRes, ILogger logger, CancellationToken cancellationToken) at Emby.Server.Implementations.HttpServer.HttpListenerHost.RequestHandler(IHttpRequest httpReq, String urlString, String host, String localPath, CancellationToken cancellationToken) [2020-07-25 09:34:12.856 +00:00] [DBG] [71] Emby.Server.Implementations.HttpServer.HttpListenerHost: Sending HTTP Response 500 in response to "http://10.79.0.125:8096/Videos/b886d888-2eac-d1cb-732d-dfde121feb39/b886d8882eacd1cb732ddfde121feb39/Subtitles/2/0/Stream.ass" ```
OVERLORD added the pull-request label 2026-02-07 06:06:11 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9657
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?