[PR #3508] Part 1: nullable Emby.DLNA #9567

New Issue

OVERLORD · 2026-02-07T06:04:35+03:00

OVERLORD commented

2026-02-07 06:04:35 +03:00

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/3508

State: closed
Merged: Yes

Trying to break this down into manageable parts.

If this change is accepted, then there is far less work and less changes to make any IRequest instance nullable.

It makes the Request object available at construction time, so the Request doesn't have to be nullable.

The request object is stored in

httpContextAccessor.HttpContext.Items["ServiceStackRequest"]

and can be accessed via:

public abcService(IHttpContextAccessor httpContextAccessor)
{
        Request = (IRequest)httpContextAccessor.HttpContext.Items["ServiceStackRequest"];
}

**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/3508 **State:** closed **Merged:** Yes --- Trying to break this down into manageable parts. If this change is accepted, then there is far less work and **less changes** to make any IRequest instance nullable. It makes the Request object available at construction time, so the Request doesn't have to be nullable. The request object is stored in ``` httpContextAccessor.HttpContext.Items["ServiceStackRequest"] ``` and can be accessed via: ``` public abcService(IHttpContextAccessor httpContextAccessor) { Request = (IRequest)httpContextAccessor.HttpContext.Items["ServiceStackRequest"]; } ```

OVERLORD added the pull-request label 2026-02-07 06:04:35 +03:00

OVERLORD closed this issue

2026-02-07 06:04:36 +03:00

Sign in to join this conversation.

Branches Tags

master

renovate/major-skiasharp-monorepo

renovate/sharpcompress-0.x

renovate/svg.skia-5.x

renovate/ghcr.io-devcontainers-features-docker-in-docker-4.x

release-10.11.z

standards-fix

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#9567