starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #3480] [MERGED] Respect FFMpeg path passed via Environment Variable #9554

New Issue
Closed
opened 2026-02-07 06:04:19 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:04:19 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3480
Author: @neilsb
Created: 6/29/2020
Status: ✅ Merged
Merged: 6/30/2020
Merged by: @anthonylavado

Base: master ← Head: ffmpeg-env-var

📝 Commits (3)

  • 4389773 Respect FFMpeg path passed via Environment Variable
  • 4748df2 Remove un-needed comment
  • 6b532b3 User string.Empty instead of ""

📊 Changes

4 files changed (+15 additions, -6 deletions)

View changed files

📝 Emby.Server.Implementations/ApplicationHost.cs (+1 -3)
📝 Jellyfin.Server/StartupOptions.cs (+5 -0)
📝 MediaBrowser.Controller/Extensions/ConfigurationExtensions.cs (+5 -0)
📝 MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs (+4 -3)

📄 Description

Fix issue whereby JELLYFIN_FFMPEG environment variable was ignored.

Changes

  • Added ffmpeg commandline param into IConfiguration
  • Updated MediaEncoder constructor to take IConfiguration instead ffmpeg path string
  • Removed custom activation for MediaEncoder

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3480 **Author:** [@neilsb](https://github.com/neilsb) **Created:** 6/29/2020 **Status:** ✅ Merged **Merged:** 6/30/2020 **Merged by:** [@anthonylavado](https://github.com/anthonylavado) **Base:** `master` ← **Head:** `ffmpeg-env-var` --- ### 📝 Commits (3) - [`4389773`](https://github.com/jellyfin/jellyfin/commit/438977350892179d5dc2259316b0fe27ceb1e5da) Respect FFMpeg path passed via Environment Variable - [`4748df2`](https://github.com/jellyfin/jellyfin/commit/4748df26b6b690f58867dbc2c39f23c44553f7a5) Remove un-needed comment - [`6b532b3`](https://github.com/jellyfin/jellyfin/commit/6b532b3da56a3f7fa0ef920a1f14ba8db70bcb35) User string.Empty instead of "" ### 📊 Changes **4 files changed** (+15 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+1 -3) 📝 `Jellyfin.Server/StartupOptions.cs` (+5 -0) 📝 `MediaBrowser.Controller/Extensions/ConfigurationExtensions.cs` (+5 -0) 📝 `MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs` (+4 -3) </details> ### 📄 Description Fix issue whereby `JELLYFIN_FFMPEG` environment variable was ignored. **Changes** - Added ffmpeg commandline param into IConfiguration - Updated MediaEncoder constructor to take IConfiguration instead ffmpeg path string - Removed custom activation for MediaEncoder --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:04:19 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9554
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?