starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #3455] [MERGED] Use constructor to set optimal config values #9540

New Issue
Closed
opened 2026-02-07 06:04:02 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:04:02 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3455
Author: @dkanada
Created: 6/26/2020
Status: ✅ Merged
Merged: 6/26/2020
Merged by: @dkanada

Base: master ← Head: values

📝 Commits (1)

  • 83ae4d0 use constructor to set optimal config values

📊 Changes

5 files changed (+4 additions, -118 deletions)

View changed files

📝 Emby.Server.Implementations/Collections/CollectionManager.cs (+0 -56)
📝 Emby.Server.Implementations/Configuration/ServerConfigurationManager.cs (+0 -57)
📝 Jellyfin.Api/Controllers/StartupController.cs (+0 -1)
📝 MediaBrowser.Controller/Configuration/IServerConfigurationManager.cs (+0 -2)
📝 MediaBrowser.Model/Configuration/ServerConfiguration.cs (+4 -2)

📄 Description

This was breaking my initial SimpleArtistDetection fix so I removed the whole thing because it seems useless. I didn't test the collection upgrade removal but it also seems like a migration routine that is way too old for us to care about.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3455 **Author:** [@dkanada](https://github.com/dkanada) **Created:** 6/26/2020 **Status:** ✅ Merged **Merged:** 6/26/2020 **Merged by:** [@dkanada](https://github.com/dkanada) **Base:** `master` ← **Head:** `values` --- ### 📝 Commits (1) - [`83ae4d0`](https://github.com/jellyfin/jellyfin/commit/83ae4d074dc9f665c992eefd1cf4ed78eb5a8dd1) use constructor to set optimal config values ### 📊 Changes **5 files changed** (+4 additions, -118 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Collections/CollectionManager.cs` (+0 -56) 📝 `Emby.Server.Implementations/Configuration/ServerConfigurationManager.cs` (+0 -57) 📝 `Jellyfin.Api/Controllers/StartupController.cs` (+0 -1) 📝 `MediaBrowser.Controller/Configuration/IServerConfigurationManager.cs` (+0 -2) 📝 `MediaBrowser.Model/Configuration/ServerConfiguration.cs` (+4 -2) </details> ### 📄 Description This was breaking my initial `SimpleArtistDetection` fix so I removed the whole thing because it seems useless. I didn't test the collection upgrade removal but it also seems like a migration routine that is way too old for us to care about. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:04:02 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9540
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?