[PR #3425] [MERGED] Revert ILoggerFactory usage in BaseItem.cs #9514

New Issue

OVERLORD · 2026-02-07T06:03:31+03:00

OVERLORD commented

2026-02-07 06:03:31 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3425
Author: @crobibero
Created: 6/23/2020
Status: ✅ Merged
Merged: 6/23/2020
Merged by: @Bond-009

Base: master ← Head: revert-baseitem-logger

📝 Commits (1)

1398c21 Revert ILoggerFactory usage in BaseItem.cs

📊 Changes

3 files changed (+4 additions, -5 deletions)

View changed files

📝 MediaBrowser.Controller/Entities/BaseItem.cs (+0 -2)
📝 MediaBrowser.Controller/Entities/UserView.cs (+1 -1)
📝 MediaBrowser.Controller/Entities/UserViewBuilder.cs (+3 -2)

📄 Description

Fixes

[2020-06-20 11:24:30.354 +03:00] [ERR] Error processing request. URL: "http://IP/jellyfin/Users/19049592d87b4ea7a149a747070f233d/Items?Fields=PrimaryImageAspectRatio%2CSortName%2CPath%2CPrimaryImageAspectRatio&ImageTypeLimit=1&ParentId=c00310d49d01f5352278e06b1b96160a&SortBy=IsFolder%2CSortName&SortOrder=Ascending"
System.ArgumentNullException: Value cannot be null. (Parameter 'factory')
   at Microsoft.Extensions.Logging.LoggerFactoryExtensions.CreateLogger[T](ILoggerFactory factory)
   at MediaBrowser.Controller.Entities.UserView.GetItemsInternal(InternalItemsQuery query)
   at MediaBrowser.Controller.Entities.Folder.GetItems(InternalItemsQuery query)
   at MediaBrowser.Api.UserLibrary.ItemsService.GetQueryResult(GetItems request, DtoOptions dtoOptions, User user)
   at MediaBrowser.Api.UserLibrary.ItemsService.GetItems(GetItems request)
   at MediaBrowser.Api.UserLibrary.ItemsService.Get(GetItems request)
   at Emby.Server.Implementations.Services.ServiceExecGeneral.Execute(Type serviceType, IRequest request, Object instance, Object requestDto, String requestName)
   at Emby.Server.Implementations.Services.ServiceController.Execute(HttpListenerHost httpHost, Object requestDto, IRequest req)
   at Emby.Server.Implementations.Services.ServiceHandler.ProcessRequestAsync(HttpListenerHost httpHost, IRequest httpReq, HttpResponse httpRes, ILogger logger, CancellationToken cancellationToken)
   at Emby.Server.Implementations.HttpServer.HttpListenerHost.RequestHandler(IHttpRequest httpReq, String urlString, String host, String localPath, CancellationToken cancellationToken)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3425 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 6/23/2020 **Status:** ✅ Merged **Merged:** 6/23/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `revert-baseitem-logger` --- ### 📝 Commits (1) - [`1398c21`](https://github.com/jellyfin/jellyfin/commit/1398c2117c8bd20cdab0c5afb5167de3fde4cd08) Revert ILoggerFactory usage in BaseItem.cs ### 📊 Changes **3 files changed** (+4 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Controller/Entities/BaseItem.cs` (+0 -2) 📝 `MediaBrowser.Controller/Entities/UserView.cs` (+1 -1) 📝 `MediaBrowser.Controller/Entities/UserViewBuilder.cs` (+3 -2) </details> ### 📄 Description Fixes ``` [2020-06-20 11:24:30.354 +03:00] [ERR] Error processing request. URL: "http://IP/jellyfin/Users/19049592d87b4ea7a149a747070f233d/Items?Fields=PrimaryImageAspectRatio%2CSortName%2CPath%2CPrimaryImageAspectRatio&ImageTypeLimit=1&ParentId=c00310d49d01f5352278e06b1b96160a&SortBy=IsFolder%2CSortName&SortOrder=Ascending" System.ArgumentNullException: Value cannot be null. (Parameter 'factory') at Microsoft.Extensions.Logging.LoggerFactoryExtensions.CreateLogger[T](ILoggerFactory factory) at MediaBrowser.Controller.Entities.UserView.GetItemsInternal(InternalItemsQuery query) at MediaBrowser.Controller.Entities.Folder.GetItems(InternalItemsQuery query) at MediaBrowser.Api.UserLibrary.ItemsService.GetQueryResult(GetItems request, DtoOptions dtoOptions, User user) at MediaBrowser.Api.UserLibrary.ItemsService.GetItems(GetItems request) at MediaBrowser.Api.UserLibrary.ItemsService.Get(GetItems request) at Emby.Server.Implementations.Services.ServiceExecGeneral.Execute(Type serviceType, IRequest request, Object instance, Object requestDto, String requestName) at Emby.Server.Implementations.Services.ServiceController.Execute(HttpListenerHost httpHost, Object requestDto, IRequest req) at Emby.Server.Implementations.Services.ServiceHandler.ProcessRequestAsync(HttpListenerHost httpHost, IRequest httpReq, HttpResponse httpRes, ILogger logger, CancellationToken cancellationToken) at Emby.Server.Implementations.HttpServer.HttpListenerHost.RequestHandler(IHttpRequest httpReq, String urlString, String host, String localPath, CancellationToken cancellationToken) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 06:03:31 +03:00

OVERLORD closed this issue

2026-02-07 06:03:33 +03:00

Sign in to join this conversation.

Branches Tags

master

renovate/major-skiasharp-monorepo

renovate/sharpcompress-0.x

renovate/svg.skia-5.x

renovate/ghcr.io-devcontainers-features-docker-in-docker-4.x

release-10.11.z

standards-fix

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#9514