starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #3418] [MERGED] Minor changes #9511

New Issue
Closed
opened 2026-02-07 06:03:28 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:03:28 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3418
Author: @Bond-009
Created: 6/22/2020
Status: ✅ Merged
Merged: 6/23/2020
Merged by: @dkanada

Base: master ← Head: minor3

📝 Commits (1)

📊 Changes

4 files changed (+22 additions, -32 deletions)

View changed files

📝 Emby.Server.Implementations/Updates/InstallationManager.cs (+6 -12)
📝 MediaBrowser.Common/Updates/IInstallationManager.cs (+1 -2)
📝 MediaBrowser.Model/Configuration/BaseApplicationConfiguration.cs (+13 -13)
📝 MediaBrowser.Model/Updates/RepositoryInfo.cs (+2 -5)

📄 Description

Minor improvements.

The properties of RepositoryInfo can be set to null with the API, this shouldn't be possible. I think we should add a DTO, validate all properties and map to RepositoryInfo.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3418 **Author:** [@Bond-009](https://github.com/Bond-009) **Created:** 6/22/2020 **Status:** ✅ Merged **Merged:** 6/23/2020 **Merged by:** [@dkanada](https://github.com/dkanada) **Base:** `master` ← **Head:** `minor3` --- ### 📝 Commits (1) - [`3d42f37`](https://github.com/jellyfin/jellyfin/commit/3d42f3753889f15f7013d0216f577a7ba6e3120c) Minor changes ### 📊 Changes **4 files changed** (+22 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Updates/InstallationManager.cs` (+6 -12) 📝 `MediaBrowser.Common/Updates/IInstallationManager.cs` (+1 -2) 📝 `MediaBrowser.Model/Configuration/BaseApplicationConfiguration.cs` (+13 -13) 📝 `MediaBrowser.Model/Updates/RepositoryInfo.cs` (+2 -5) </details> ### 📄 Description Minor improvements. The properties of RepositoryInfo can be set to `null` with the API, this shouldn't be possible. I think we should add a DTO, validate all properties and map to RepositoryInfo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:03:28 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9511
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?