[PR #3409] [MERGED] Fix scan crashed #9505

Closed
opened 2026-02-07 06:03:20 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3409
Author: @Bond-009
Created: 6/22/2020
Status: Merged
Merged: 6/22/2020
Merged by: @anthonylavado

Base: masterHead: scanerror


📝 Commits (1)

📊 Changes

2 files changed (+6 additions, -3 deletions)

View changed files

📝 Emby.Server.Implementations/Library/LibraryManager.cs (+2 -1)
📝 MediaBrowser.Providers/Manager/ItemImageProvider.cs (+4 -2)

📄 Description

[2020-06-22 00:09:19.370 +02:00] [ERR] [6] Emby.Server.Implementations.ScheduledTasks.TaskManager: Error
MediaBrowser.Model.Net.HttpException: Forbidden
   at Emby.Server.Implementations.HttpClientManager.HttpClientManager.EnsureSuccessStatusCode(HttpResponseMessage response, HttpRequestOptions options) in /home/loma/dev/jellyfin/Emby.Server.Implementations/HttpClientManager/HttpClientManager.cs:line 333
   at Emby.Server.Implementations.HttpClientManager.HttpClientManager.SendAsyncInternal(HttpRequestOptions options, HttpMethod httpMethod) in /home/loma/dev/jellyfin/Emby.Server.Implementations/HttpClientManager/HttpClientManager.cs:line 279
   at Emby.Server.Implementations.HttpClientManager.HttpClientManager.SendAsync(HttpRequestOptions options, HttpMethod httpMethod) in /home/loma/dev/jellyfin/Emby.Server.Implementations/HttpClientManager/HttpClientManager.cs:line 194
   at MediaBrowser.Providers.Manager.ProviderManager.SaveImage(BaseItem item, String url, ImageType type, Nullable`1 imageIndex, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Providers/Manager/ProviderManager.cs:line 172
   at Emby.Server.Implementations.Library.LibraryManager.ConvertImageToLocal(BaseItem item, ItemImageInfo image, Int32 imageIndex) in /home/loma/dev/jellyfin/Emby.Server.Implementations/Library/LibraryManager.cs:line 2894
   at Emby.Server.Implementations.Library.LibraryManager.UpdateImages(BaseItem item, Boolean forceUpdate) in /home/loma/dev/jellyfin/Emby.Server.Implementations/Library/LibraryManager.cs:line 1863
   at Emby.Server.Implementations.Library.LibraryManager.UpdateItems(IEnumerable`1 items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/Emby.Server.Implementations/Library/LibraryManager.cs:line 1942
   at Emby.Server.Implementations.Library.LibraryManager.UpdateItem(BaseItem item, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/Emby.Server.Implementations/Library/LibraryManager.cs:line 1986
   at MediaBrowser.Controller.Entities.BaseItem.UpdateToRepository(ItemUpdateType updateReason, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/BaseItem.cs:line 2316
   at MediaBrowser.Providers.Manager.MetadataService`2.SavePeopleMetadata(List`1 people, LibraryOptions libraryOptions, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Providers/Manager/MetadataService.cs:line 250
   at MediaBrowser.Providers.Manager.MetadataService`2.SaveItem(MetadataResult`1 result, LibraryOptions libraryOptions, ItemUpdateType reason, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Providers/Manager/MetadataService.cs:line 217
   at MediaBrowser.Providers.Manager.MetadataService`2.RefreshMetadata(BaseItem item, MetadataRefreshOptions refreshOptions, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Providers/Manager/MetadataService.cs:line 197
   at MediaBrowser.Controller.Entities.BaseItem.RefreshMetadata(MetadataRefreshOptions options, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/BaseItem.cs:line 1421
   at MediaBrowser.Controller.Entities.Folder.RefreshAllMetadataForContainer(IMetadataContainer container, MetadataRefreshOptions refreshOptions, IProgress`1 progress, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/Folder.cs:line 508
   at MediaBrowser.Controller.Entities.Folder.RefreshChildMetadata(BaseItem child, MetadataRefreshOptions refreshOptions, Boolean recursive, IProgress`1 progress, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/Folder.cs:line 531
   at MediaBrowser.Controller.Entities.Folder.RefreshMetadataRecursive(List`1 children, MetadataRefreshOptions refreshOptions, Boolean recursive, IProgress`1 progress, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/Folder.cs:line 490
   at MediaBrowser.Controller.Entities.Folder.RefreshChildMetadata(BaseItem child, MetadataRefreshOptions refreshOptions, Boolean recursive, IProgress`1 progress, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/Folder.cs:line 531
   at MediaBrowser.Controller.Entities.Folder.RefreshMetadataRecursive(List`1 children, MetadataRefreshOptions refreshOptions, Boolean recursive, IProgress`1 progress, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/Folder.cs:line 490
   at MediaBrowser.Controller.Entities.Folder.ValidateChildrenInternal2(IProgress`1 progress, CancellationToken cancellationToken, Boolean recursive, Boolean refreshChildMetadata, MetadataRefreshOptions refreshOptions, IDirectoryService directoryService) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/Folder.cs:line 460
   at MediaBrowser.Controller.Entities.Folder.ValidateChildrenInternal(IProgress`1 progress, CancellationToken cancellationToken, Boolean recursive, Boolean refreshChildMetadata, MetadataRefreshOptions refreshOptions, IDirectoryService directoryService) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/Folder.cs:line 307
   at MediaBrowser.Controller.Entities.AggregateFolder.ValidateChildrenInternal(IProgress`1 progress, CancellationToken cancellationToken, Boolean recursive, Boolean refreshChildMetadata, MetadataRefreshOptions refreshOptions, IDirectoryService directoryService) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/AggregateFolder.cs:line 160
   at Emby.Server.Implementations.Library.LibraryManager.PerformLibraryValidation(IProgress`1 progress, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/Emby.Server.Implementations/Library/LibraryManager.cs:line 1076
   at Emby.Server.Implementations.Library.LibraryManager.ValidateMediaLibraryInternal(IProgress`1 progress, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/Emby.Server.Implementations/Library/LibraryManager.cs:line 1028
   at Emby.Server.Implementations.ScheduledTasks.ScheduledTaskWorker.ExecuteInternal(TaskOptions options) in /home/loma/dev/jellyfin/Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs:line 418

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3409 **Author:** [@Bond-009](https://github.com/Bond-009) **Created:** 6/22/2020 **Status:** ✅ Merged **Merged:** 6/22/2020 **Merged by:** [@anthonylavado](https://github.com/anthonylavado) **Base:** `master` ← **Head:** `scanerror` --- ### 📝 Commits (1) - [`f75024f`](https://github.com/jellyfin/jellyfin/commit/f75024fadea23f374fc865c8da07814cc9b3b3c9) Fix scan crashed ### 📊 Changes **2 files changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+2 -1) 📝 `MediaBrowser.Providers/Manager/ItemImageProvider.cs` (+4 -2) </details> ### 📄 Description ``` [2020-06-22 00:09:19.370 +02:00] [ERR] [6] Emby.Server.Implementations.ScheduledTasks.TaskManager: Error MediaBrowser.Model.Net.HttpException: Forbidden at Emby.Server.Implementations.HttpClientManager.HttpClientManager.EnsureSuccessStatusCode(HttpResponseMessage response, HttpRequestOptions options) in /home/loma/dev/jellyfin/Emby.Server.Implementations/HttpClientManager/HttpClientManager.cs:line 333 at Emby.Server.Implementations.HttpClientManager.HttpClientManager.SendAsyncInternal(HttpRequestOptions options, HttpMethod httpMethod) in /home/loma/dev/jellyfin/Emby.Server.Implementations/HttpClientManager/HttpClientManager.cs:line 279 at Emby.Server.Implementations.HttpClientManager.HttpClientManager.SendAsync(HttpRequestOptions options, HttpMethod httpMethod) in /home/loma/dev/jellyfin/Emby.Server.Implementations/HttpClientManager/HttpClientManager.cs:line 194 at MediaBrowser.Providers.Manager.ProviderManager.SaveImage(BaseItem item, String url, ImageType type, Nullable`1 imageIndex, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Providers/Manager/ProviderManager.cs:line 172 at Emby.Server.Implementations.Library.LibraryManager.ConvertImageToLocal(BaseItem item, ItemImageInfo image, Int32 imageIndex) in /home/loma/dev/jellyfin/Emby.Server.Implementations/Library/LibraryManager.cs:line 2894 at Emby.Server.Implementations.Library.LibraryManager.UpdateImages(BaseItem item, Boolean forceUpdate) in /home/loma/dev/jellyfin/Emby.Server.Implementations/Library/LibraryManager.cs:line 1863 at Emby.Server.Implementations.Library.LibraryManager.UpdateItems(IEnumerable`1 items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/Emby.Server.Implementations/Library/LibraryManager.cs:line 1942 at Emby.Server.Implementations.Library.LibraryManager.UpdateItem(BaseItem item, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/Emby.Server.Implementations/Library/LibraryManager.cs:line 1986 at MediaBrowser.Controller.Entities.BaseItem.UpdateToRepository(ItemUpdateType updateReason, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/BaseItem.cs:line 2316 at MediaBrowser.Providers.Manager.MetadataService`2.SavePeopleMetadata(List`1 people, LibraryOptions libraryOptions, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Providers/Manager/MetadataService.cs:line 250 at MediaBrowser.Providers.Manager.MetadataService`2.SaveItem(MetadataResult`1 result, LibraryOptions libraryOptions, ItemUpdateType reason, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Providers/Manager/MetadataService.cs:line 217 at MediaBrowser.Providers.Manager.MetadataService`2.RefreshMetadata(BaseItem item, MetadataRefreshOptions refreshOptions, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Providers/Manager/MetadataService.cs:line 197 at MediaBrowser.Controller.Entities.BaseItem.RefreshMetadata(MetadataRefreshOptions options, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/BaseItem.cs:line 1421 at MediaBrowser.Controller.Entities.Folder.RefreshAllMetadataForContainer(IMetadataContainer container, MetadataRefreshOptions refreshOptions, IProgress`1 progress, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/Folder.cs:line 508 at MediaBrowser.Controller.Entities.Folder.RefreshChildMetadata(BaseItem child, MetadataRefreshOptions refreshOptions, Boolean recursive, IProgress`1 progress, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/Folder.cs:line 531 at MediaBrowser.Controller.Entities.Folder.RefreshMetadataRecursive(List`1 children, MetadataRefreshOptions refreshOptions, Boolean recursive, IProgress`1 progress, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/Folder.cs:line 490 at MediaBrowser.Controller.Entities.Folder.RefreshChildMetadata(BaseItem child, MetadataRefreshOptions refreshOptions, Boolean recursive, IProgress`1 progress, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/Folder.cs:line 531 at MediaBrowser.Controller.Entities.Folder.RefreshMetadataRecursive(List`1 children, MetadataRefreshOptions refreshOptions, Boolean recursive, IProgress`1 progress, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/Folder.cs:line 490 at MediaBrowser.Controller.Entities.Folder.ValidateChildrenInternal2(IProgress`1 progress, CancellationToken cancellationToken, Boolean recursive, Boolean refreshChildMetadata, MetadataRefreshOptions refreshOptions, IDirectoryService directoryService) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/Folder.cs:line 460 at MediaBrowser.Controller.Entities.Folder.ValidateChildrenInternal(IProgress`1 progress, CancellationToken cancellationToken, Boolean recursive, Boolean refreshChildMetadata, MetadataRefreshOptions refreshOptions, IDirectoryService directoryService) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/Folder.cs:line 307 at MediaBrowser.Controller.Entities.AggregateFolder.ValidateChildrenInternal(IProgress`1 progress, CancellationToken cancellationToken, Boolean recursive, Boolean refreshChildMetadata, MetadataRefreshOptions refreshOptions, IDirectoryService directoryService) in /home/loma/dev/jellyfin/MediaBrowser.Controller/Entities/AggregateFolder.cs:line 160 at Emby.Server.Implementations.Library.LibraryManager.PerformLibraryValidation(IProgress`1 progress, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/Emby.Server.Implementations/Library/LibraryManager.cs:line 1076 at Emby.Server.Implementations.Library.LibraryManager.ValidateMediaLibraryInternal(IProgress`1 progress, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/Emby.Server.Implementations/Library/LibraryManager.cs:line 1028 at Emby.Server.Implementations.ScheduledTasks.ScheduledTaskWorker.ExecuteInternal(TaskOptions options) in /home/loma/dev/jellyfin/Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs:line 418 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:03:20 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9505