starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #3395] [MERGED] Add missing attributes, fix response codes, fix route parameter casing #9499

New Issue
Closed
opened 2026-02-07 06:03:14 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:03:14 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3395
Author: @crobibero
Created: 6/21/2020
Status: ✅ Merged
Merged: 6/21/2020
Merged by: @barronpm

Base: api-migration ← Head: api-routes-fix

📝 Commits (5)

  • 10ddbc3 Add missing attributes, fix response codes, fix route parameter casing
  • c492c09 Update Jellyfin.Api/Controllers/DisplayPreferencesController.cs
  • 857eb0c Update Jellyfin.Api/Controllers/PluginsController.cs
  • f6972cd Update Jellyfin.Api/Controllers/ItemRefreshController.cs
  • f211a6c Update Jellyfin.Api/Controllers/PluginsController.cs

📊 Changes

13 files changed (+175 additions, -166 deletions)

View changed files

📝 Jellyfin.Api/Controllers/ConfigurationController.cs (+2 -2)
📝 Jellyfin.Api/Controllers/DevicesController.cs (+1 -0)
📝 Jellyfin.Api/Controllers/DisplayPreferencesController.cs (+8 -14)
📝 Jellyfin.Api/Controllers/ImageByNameController.cs (+3 -3)
📝 Jellyfin.Api/Controllers/ItemRefreshController.cs (+9 -8)
📝 Jellyfin.Api/Controllers/NotificationsController.cs (+4 -4)
📝 Jellyfin.Api/Controllers/PackageController.cs (+10 -9)
📝 Jellyfin.Api/Controllers/PluginsController.cs (+22 -10)
📝 Jellyfin.Api/Controllers/RemoteImageController.cs (+15 -15)
📝 Jellyfin.Api/Controllers/SessionController.cs (+36 -36)
📝 Jellyfin.Api/Controllers/SubtitleController.cs (+27 -27)
📝 Jellyfin.Api/Controllers/UserController.cs (+37 -37)
📝 Jellyfin.Api/Controllers/VideoAttachmentsController.cs (+1 -1)

📄 Description

Route parameters are case sensitive.
Some responses still returned Ok()
GetSubtitle has an optional route parameter with a default value of 0

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3395 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 6/21/2020 **Status:** ✅ Merged **Merged:** 6/21/2020 **Merged by:** [@barronpm](https://github.com/barronpm) **Base:** `api-migration` ← **Head:** `api-routes-fix` --- ### 📝 Commits (5) - [`10ddbc3`](https://github.com/jellyfin/jellyfin/commit/10ddbc34ecfc5542f3b32fe3cc4740e30b62cccd) Add missing attributes, fix response codes, fix route parameter casing - [`c492c09`](https://github.com/jellyfin/jellyfin/commit/c492c09b2568af5bf179f617dc192012969a8602) Update Jellyfin.Api/Controllers/DisplayPreferencesController.cs - [`857eb0c`](https://github.com/jellyfin/jellyfin/commit/857eb0c397e742be0813d2bbed4231cbd356d556) Update Jellyfin.Api/Controllers/PluginsController.cs - [`f6972cd`](https://github.com/jellyfin/jellyfin/commit/f6972cdab89efeb7792f740f97f6685ad904f82b) Update Jellyfin.Api/Controllers/ItemRefreshController.cs - [`f211a6c`](https://github.com/jellyfin/jellyfin/commit/f211a6c17b9171b2d1191b3a35ac8f34490ff0cc) Update Jellyfin.Api/Controllers/PluginsController.cs ### 📊 Changes **13 files changed** (+175 additions, -166 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/ConfigurationController.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/DevicesController.cs` (+1 -0) 📝 `Jellyfin.Api/Controllers/DisplayPreferencesController.cs` (+8 -14) 📝 `Jellyfin.Api/Controllers/ImageByNameController.cs` (+3 -3) 📝 `Jellyfin.Api/Controllers/ItemRefreshController.cs` (+9 -8) 📝 `Jellyfin.Api/Controllers/NotificationsController.cs` (+4 -4) 📝 `Jellyfin.Api/Controllers/PackageController.cs` (+10 -9) 📝 `Jellyfin.Api/Controllers/PluginsController.cs` (+22 -10) 📝 `Jellyfin.Api/Controllers/RemoteImageController.cs` (+15 -15) 📝 `Jellyfin.Api/Controllers/SessionController.cs` (+36 -36) 📝 `Jellyfin.Api/Controllers/SubtitleController.cs` (+27 -27) 📝 `Jellyfin.Api/Controllers/UserController.cs` (+37 -37) 📝 `Jellyfin.Api/Controllers/VideoAttachmentsController.cs` (+1 -1) </details> ### 📄 Description Route parameters are case sensitive. Some responses still returned `Ok()` GetSubtitle has an optional route parameter with a default value of 0 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:03:14 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9499
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?