starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #3359] [CLOSED] UDP Fix #9477

New Issue
Closed
opened 2026-02-07 06:02:50 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:02:50 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3359
Author: @BaronGreenback
Created: 6/17/2020
Status: ❌ Closed

Base: master ← Head: udpfix

📝 Commits (2)

📊 Changes

3 files changed (+5 additions, -20 deletions)

View changed files

📝 Emby.Server.Implementations/EntryPoints/UdpServerEntryPoint.cs (+1 -1)
📝 Emby.Server.Implementations/Net/UdpSocket.cs (+1 -1)
📝 Emby.Server.Implementations/Udp/UdpServer.cs (+3 -18)

📄 Description

App was causing a crash everytime it was shut down in development. This was due to objects being manually disposed in the Dispose function of the class that created them, whilst there was still an async function in operation. (resulting in a Null pointer, caught in an exception loop).

udp /udpsocket.cs

  • removed IDisposeable interface.
    Was only used to dispose _udpsocket, which caused a crash in BeginReceiveAsync as it's was still running.
  • Removed Task.Run and change start to async.

net / udpsocket.cs

  • commented out _socket.dispose. same as above, the async function was still running at dispose thus causing a crash.

entrypoints / udpserverentrypoints.cs

  • similar. Don't destroy async items.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3359 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 6/17/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `udpfix` --- ### 📝 Commits (2) - [`b2e1d70`](https://github.com/jellyfin/jellyfin/commit/b2e1d7019130f7bf7e74c8af29927226fb30d46c) Merge pull request #24 from jellyfin/master - [`3f797c7`](https://github.com/jellyfin/jellyfin/commit/3f797c728effd1cf7f114fca52924a286b80af73) udp / udpSocket.cs ### 📊 Changes **3 files changed** (+5 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/EntryPoints/UdpServerEntryPoint.cs` (+1 -1) 📝 `Emby.Server.Implementations/Net/UdpSocket.cs` (+1 -1) 📝 `Emby.Server.Implementations/Udp/UdpServer.cs` (+3 -18) </details> ### 📄 Description App was causing a crash everytime it was shut down in development. This was due to objects being manually disposed in the Dispose function of the class that created them, whilst there was still an async function in operation. (resulting in a Null pointer, caught in an exception loop). udp /udpsocket.cs - removed IDisposeable interface. Was only used to dispose _udpsocket, which caused a crash in BeginReceiveAsync as it's was still running. - Removed Task.Run and change start to async. net / udpsocket.cs - commented out _socket.dispose. same as above, the async function was still running at dispose thus causing a crash. entrypoints / udpserverentrypoints.cs - similar. Don't destroy async items. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:02:50 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9477
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?