starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #3255] [MERGED] Make books resumable #9397

New Issue
Closed
opened 2026-02-07 06:01:30 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:01:30 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3255
Author: @itegulov
Created: 6/6/2020
Status: ✅ Merged
Merged: 6/7/2020
Merged by: @dkanada

Base: master ← Head: books-resume

📝 Commits (1)

  • 613748b Make books resumable and have duration of 1 second

📊 Changes

2 files changed (+10 additions, -1 deletions)

View changed files

📝 Emby.Server.Implementations/Library/UserDataManager.cs (+1 -1)
📝 MediaBrowser.Controller/Entities/Book.cs (+9 -0)

📄 Description

Changes
This PR introduces the necessary changes to make jellyfin-web be able to resume books since https://github.com/jellyfin/jellyfin-web/pull/1263 is merged.

  • Sets SupportsPlayedStatus and SupportsPositionTicksResume to true for books. These properties have to be true for an item to be able to store position ticks.
  • Sets book's runtime ticks to 1 second. There is no cross-device way to determine the amount of pages a book has as it depends on screen resolution, font etc. Essentially jellyfin-web just reports a percentage progress through the book tied to CFI locations.
  • Excludes books from minimum resumable duration check as books don't really have a time duration and 1 second is just a mock value.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3255 **Author:** [@itegulov](https://github.com/itegulov) **Created:** 6/6/2020 **Status:** ✅ Merged **Merged:** 6/7/2020 **Merged by:** [@dkanada](https://github.com/dkanada) **Base:** `master` ← **Head:** `books-resume` --- ### 📝 Commits (1) - [`613748b`](https://github.com/jellyfin/jellyfin/commit/613748b45da34e829b206b3437b50459a15207e4) Make books resumable and have duration of 1 second ### 📊 Changes **2 files changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/UserDataManager.cs` (+1 -1) 📝 `MediaBrowser.Controller/Entities/Book.cs` (+9 -0) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** This PR introduces the necessary changes to make jellyfin-web be able to resume books since https://github.com/jellyfin/jellyfin-web/pull/1263 is merged. * Sets `SupportsPlayedStatus` and `SupportsPositionTicksResume` to true for books. These properties have to be true for an item to be able to store position ticks. * Sets book's runtime ticks to 1 second. There is no cross-device way to determine the amount of pages a book has as it depends on screen resolution, font etc. Essentially jellyfin-web just reports a percentage progress through the book tied to [CFI](http://idpf.org/epub/linking/cfi/epub-cfi.html) locations. * Excludes books from minimum resumable duration check as books don't really have a time duration and 1 second is just a mock value. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:01:30 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9397
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?