mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
[PR #3250] [MERGED] Ignore languages with null ids when fetching images from tvdb #9393
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/3250
Author: @shayaantx
Created: 6/5/2020
Status: ✅ Merged
Merged: 6/7/2020
Merged by: @dkanada
Base:
master← Head:master📝 Commits (2)
4623cb8Ignore languages with null ids42bbfa7Update TvdbSeasonImageProvider.cs📊 Changes
2 files changed (+3 additions, -2 deletions)
View changed files
📝
MediaBrowser.Providers/MediaBrowser.Providers.csproj(+1 -1)📝
MediaBrowser.Providers/Plugins/TheTvdb/TvdbSeasonImageProvider.cs(+2 -1)📄 Description
Changes
After https://github.com/HristoKolev/TvDbSharper/issues/20 was fixed in TvDbSharper we can now ignore languages that have a null id, which is currently causing images to not be fetched for tvdb show meta data (currently its failing to retrieve all languages regardless if they are valid or not).
I am assuming ignoring invalid languages is the right approach since why consider a language record with no id value.
I'm unaware if this minor change warrants a test case, please let me know, and I will add one.
Issues
https://github.com/jellyfin/jellyfin/issues/3201
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.