[PR #3250] [MERGED] Ignore languages with null ids when fetching images from tvdb #9393

Closed
opened 2026-02-07 06:01:25 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3250
Author: @shayaantx
Created: 6/5/2020
Status: Merged
Merged: 6/7/2020
Merged by: @dkanada

Base: masterHead: master


📝 Commits (2)

  • 4623cb8 Ignore languages with null ids
  • 42bbfa7 Update TvdbSeasonImageProvider.cs

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 MediaBrowser.Providers/MediaBrowser.Providers.csproj (+1 -1)
📝 MediaBrowser.Providers/Plugins/TheTvdb/TvdbSeasonImageProvider.cs (+2 -1)

📄 Description

Changes
After https://github.com/HristoKolev/TvDbSharper/issues/20 was fixed in TvDbSharper we can now ignore languages that have a null id, which is currently causing images to not be fetched for tvdb show meta data (currently its failing to retrieve all languages regardless if they are valid or not).

I am assuming ignoring invalid languages is the right approach since why consider a language record with no id value.

I'm unaware if this minor change warrants a test case, please let me know, and I will add one.

Issues
https://github.com/jellyfin/jellyfin/issues/3201


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3250 **Author:** [@shayaantx](https://github.com/shayaantx) **Created:** 6/5/2020 **Status:** ✅ Merged **Merged:** 6/7/2020 **Merged by:** [@dkanada](https://github.com/dkanada) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`4623cb8`](https://github.com/jellyfin/jellyfin/commit/4623cb8385d95f6f137f003bab5cc30861d69a64) Ignore languages with null ids - [`42bbfa7`](https://github.com/jellyfin/jellyfin/commit/42bbfa772f551e376eb98c838e2ec541f905521f) Update TvdbSeasonImageProvider.cs ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/MediaBrowser.Providers.csproj` (+1 -1) 📝 `MediaBrowser.Providers/Plugins/TheTvdb/TvdbSeasonImageProvider.cs` (+2 -1) </details> ### 📄 Description **Changes** After https://github.com/HristoKolev/TvDbSharper/issues/20 was fixed in TvDbSharper we can now ignore languages that have a null id, which is currently causing images to **not** be fetched for tvdb show meta data (currently its failing to retrieve all languages regardless if they are valid or not). I am assuming ignoring _invalid_ languages is the right approach since why consider a language record with no id value. I'm unaware if this minor change warrants a test case, please let me know, and I will add one. **Issues** https://github.com/jellyfin/jellyfin/issues/3201 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:01:25 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9393