starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #3214] [MERGED] Order ids to merge to avoid stack overflow #9377

New Issue
Closed
opened 2026-02-07 06:01:08 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:01:08 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3214
Author: @danieladov
Created: 5/31/2020
Status: ✅ Merged
Merged: 5/31/2020
Merged by: @Bond-009

Base: master ← Head: master

📝 Commits (3)

  • 1b90798 Order ids to merge to avoid stack overflow
  • 8e0b110 refactor
  • be5ce32 refactor MediaBrowser.Api/VideosService.cs

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 MediaBrowser.Api/VideosService.cs (+1 -0)

📄 Description

As said in https://github.com/jellyfin/jellyfin/issues/3176, merging 1 with 2 and then 2 with 1 cause a stack overflow. sorting ids first fix the problem

Changes
Now the list of ids to merge is sort before merging

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3214 **Author:** [@danieladov](https://github.com/danieladov) **Created:** 5/31/2020 **Status:** ✅ Merged **Merged:** 5/31/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`1b90798`](https://github.com/jellyfin/jellyfin/commit/1b90798b90fc4e5f7fe8d813c34c87f519924abc) Order ids to merge to avoid stack overflow - [`8e0b110`](https://github.com/jellyfin/jellyfin/commit/8e0b1109bc3a2e63474576012b4a2ddcd9e5313e) refactor - [`be5ce32`](https://github.com/jellyfin/jellyfin/commit/be5ce32bb6c7d1eba5863428eb9cb9c9f8a4e7f8) refactor MediaBrowser.Api/VideosService.cs ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Api/VideosService.cs` (+1 -0) </details> ### 📄 Description As said in https://github.com/jellyfin/jellyfin/issues/3176, merging 1 with 2 and then 2 with 1 cause a stack overflow. sorting ids first fix the problem **Changes** Now the list of ids to merge is sort before merging --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:01:08 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9377
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?