starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #3164] [MERGED] Fix a few issues with the plugin manifest #9365

New Issue
Closed
opened 2026-02-07 06:00:54 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:00:54 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3164
Author: @dkanada
Created: 5/24/2020
Status: ✅ Merged
Merged: 6/4/2020
Merged by: @dkanada

Base: master ← Head: install-plugin

📝 Commits (8)

  • 7972daa fix a few issues with the plugin manifest
  • 6d3e5d8 update error log for plugin download
  • deafe59 add the timestamp property back to the version info
  • 6a7cb21 apply code suggestions
  • 7176a9a fix build issues
  • fe16c3f Merge branch 'master' into install-plugin
  • 9661135 fix build
  • 2ac111d add missing ConfigureAwait

📊 Changes

7 files changed (+114 additions, -128 deletions)

View changed files

📝 Emby.Server.Implementations/Activity/ActivityLogEntryPoint.cs (+9 -9)
📝 Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs (+9 -8)
📝 Emby.Server.Implementations/ScheduledTasks/Tasks/PluginUpdateTask.cs (+2 -2)
📝 Emby.Server.Implementations/Updates/InstallationManager.cs (+61 -72)
📝 MediaBrowser.Common/Updates/IInstallationManager.cs (+9 -19)
📝 MediaBrowser.Model/Updates/InstallationInfo.cs (+20 -2)
📝 MediaBrowser.Model/Updates/VersionInfo.cs (+4 -16)

📄 Description

This removes the last of the annoying properties from the version and package info classes. The installation is now used internally to collect data from both classes, but at some point we could also start using a tuple instead.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3164 **Author:** [@dkanada](https://github.com/dkanada) **Created:** 5/24/2020 **Status:** ✅ Merged **Merged:** 6/4/2020 **Merged by:** [@dkanada](https://github.com/dkanada) **Base:** `master` ← **Head:** `install-plugin` --- ### 📝 Commits (8) - [`7972daa`](https://github.com/jellyfin/jellyfin/commit/7972daaba43f48e5047f232f0ec1475fc8648b16) fix a few issues with the plugin manifest - [`6d3e5d8`](https://github.com/jellyfin/jellyfin/commit/6d3e5d86626fb4d3ac80ad52b9446522ddfc9047) update error log for plugin download - [`deafe59`](https://github.com/jellyfin/jellyfin/commit/deafe59b7ef4651415280255335b9b5e3f4dcacb) add the timestamp property back to the version info - [`6a7cb21`](https://github.com/jellyfin/jellyfin/commit/6a7cb21b7e4223a78857772e56539f1e344600f5) apply code suggestions - [`7176a9a`](https://github.com/jellyfin/jellyfin/commit/7176a9a30a7c9c925e04529f3ba7feac022f9248) fix build issues - [`fe16c3f`](https://github.com/jellyfin/jellyfin/commit/fe16c3fad4b3ea2cab0ec4a4008e31be626b5eee) Merge branch 'master' into install-plugin - [`9661135`](https://github.com/jellyfin/jellyfin/commit/9661135b5b089b57e19cca4ac4f5d17ab475c8d6) fix build - [`2ac111d`](https://github.com/jellyfin/jellyfin/commit/2ac111dedba416850d526f9f60dbf82f2bd28edd) add missing ConfigureAwait ### 📊 Changes **7 files changed** (+114 additions, -128 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Activity/ActivityLogEntryPoint.cs` (+9 -9) 📝 `Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs` (+9 -8) 📝 `Emby.Server.Implementations/ScheduledTasks/Tasks/PluginUpdateTask.cs` (+2 -2) 📝 `Emby.Server.Implementations/Updates/InstallationManager.cs` (+61 -72) 📝 `MediaBrowser.Common/Updates/IInstallationManager.cs` (+9 -19) 📝 `MediaBrowser.Model/Updates/InstallationInfo.cs` (+20 -2) 📝 `MediaBrowser.Model/Updates/VersionInfo.cs` (+4 -16) </details> ### 📄 Description This removes the last of the annoying properties from the version and package info classes. The installation is now used internally to collect data from both classes, but at some point we could also start using a tuple instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:00:54 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9365
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?