starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #3085] [MERGED] Add positionning cues to WebVTT writer #9340

New Issue
Closed
opened 2026-02-07 06:00:30 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:00:30 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3085
Author: @heyhippari
Created: 5/9/2020
Status: ✅ Merged
Merged: 5/15/2020
Merged by: @dkanada

Base: master ← Head: vtt-position

📝 Commits (1)

  • a262ecd Add positionning cues to WebVTT writer

📊 Changes

1 file changed (+13 additions, -2 deletions)

View changed files

📝 MediaBrowser.MediaEncoding/Subtitles/VttWriter.cs (+13 -2)

📄 Description

Changes

Adds a Region to the VttWriter to instruct clients where to render the subtitles.

Based on the W3C specs found here: https://www.w3.org/TR/webvtt1/#region-settings

Issues

Goes in tandem with https://github.com/jellyfin/jellyfin-web/pull/1209 to provide a decent display region for clients that support WebVTT.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3085 **Author:** [@heyhippari](https://github.com/heyhippari) **Created:** 5/9/2020 **Status:** ✅ Merged **Merged:** 5/15/2020 **Merged by:** [@dkanada](https://github.com/dkanada) **Base:** `master` ← **Head:** `vtt-position` --- ### 📝 Commits (1) - [`a262ecd`](https://github.com/jellyfin/jellyfin/commit/a262ecd9c77b0e906288de0890aee2d5dcad6ae4) Add positionning cues to WebVTT writer ### 📊 Changes **1 file changed** (+13 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.MediaEncoding/Subtitles/VttWriter.cs` (+13 -2) </details> ### 📄 Description **Changes** Adds a Region to the VttWriter to instruct clients where to render the subtitles. Based on the W3C specs found here: https://www.w3.org/TR/webvtt1/#region-settings **Issues** Goes in tandem with https://github.com/jellyfin/jellyfin-web/pull/1209 to provide a decent display region for clients that support WebVTT. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:00:30 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9340
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?