[PR #2937] [CLOSED] Fix warning SA1694 #9282

New Issue

OVERLORD · 2026-02-07T05:59:26+03:00

OVERLORD commented

2026-02-07 05:59:26 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/2937
Author: @kekonn
Created: 4/20/2020
Status: ❌ Closed

Base: master ← Head: fix-sa1694

📝 Commits (10+)

fab151b Fix warning SA1694
96c11be Update MediaBrowser.Providers/Movies/ImdbPersonExternalId.cs
330c731 Incorporating change requests for PR 2937
a420004 Merge branch 'fix-sa1694' of https://github.com/bloodsplatter/jellyfin into fix-sa1694
edf0104 Update MediaBrowser.Providers/Plugins/AudioDb/AudioDbAlbumProvider.cs
ec9a1dd Apply suggestions from code review, again.
dfbe86a Spelling fix in AudioDbOtherAlbumExternalId.cs
ee62d6f Forgot an xml comment on TvdbEpisodeExternalId
e96d36a Fixing spelling mistakes and adopting wording suggestions
cea21f7 Adding more documentation to extracted classes

📊 Changes

43 files changed (+476 additions, -272 deletions)

View changed files

📝 Emby.Dlna/Api/DlnaServerService.cs (+2 -0)
📝 Emby.Dlna/Api/DlnaService.cs (+2 -0)
📝 Emby.Server.Implementations/Library/Resolvers/GenericVideoResolver{T}.cs (+0 -0)
📝 Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunManager.cs (+1 -0)
📝 Emby.Server.Implementations/Playlists/PlaylistsFolder.cs (+0 -0)
📝 Emby.Server.Implementations/Services/RestPath.cs (+2 -0)
📝 Emby.Server.Implementations/Services/ServiceExec.cs (+2 -0)
📝 Emby.Server.Implementations/Services/SwaggerService.cs (+2 -0)
📝 Emby.Server.Implementations/UserViews/FolderImageProvider.cs (+2 -0)
➕ MediaBrowser.Controller/Collections/CollectionCreatedEventArgs.cs (+22 -0)
📝 MediaBrowser.Controller/Collections/CollectionModifiedEventArgs.cs (+0 -14)
📝 MediaBrowser.Controller/Entities/Share.cs (+6 -5)
📝 MediaBrowser.Controller/Resolvers/ItemResolver.cs (+0 -0)
📝 MediaBrowser.Providers/LiveTv/LiveTvMetadataService.cs (+0 -0)
📝 MediaBrowser.Providers/Movies/ImdbExternalId.cs (+1 -16)
➕ MediaBrowser.Providers/Movies/ImdbPersonExternalId.cs (+24 -0)
📝 MediaBrowser.Providers/Movies/MovieMetadataService.cs (+13 -0)
📝 MediaBrowser.Providers/Music/ImvdbId.cs (+0 -0)
➕ MediaBrowser.Providers/Plugins/AudioDb/AudioDbAlbumExternalId.cs (+24 -0)
📝 MediaBrowser.Providers/Plugins/AudioDb/AudioDbAlbumImageProvider.cs (+9 -0)

...and 23 more files

📄 Description

By pragma or renaming files.

In the Emby.Dlna namespace I've left the Route/Api definitions in their files with the service, since moving these outside of those files creates an ambiguity problem that can't be fixed without adding a namespace or actually changing symbol names.

Changes
Warnings in Emby.Server.Implementations have been silenced by a #pragma at the top of the file. In other namespaces this is fixed by moving classes out to their separate files or renaming files. No symbol changes were made. In some files, this created unused using statements, which have been cleaned up.

Issues
Helps with #2149

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/2937 **Author:** [@kekonn](https://github.com/kekonn) **Created:** 4/20/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-sa1694` --- ### 📝 Commits (10+) - [`fab151b`](https://github.com/jellyfin/jellyfin/commit/fab151b5a3914996b3507980b028bdc41f0a988a) Fix warning SA1694 - [`96c11be`](https://github.com/jellyfin/jellyfin/commit/96c11bef6c1519f94d71f8163ae05df2e9d29096) Update MediaBrowser.Providers/Movies/ImdbPersonExternalId.cs - [`330c731`](https://github.com/jellyfin/jellyfin/commit/330c731eef00d974ab67bbd0ae03cd1b8b6f37ea) Incorporating change requests for PR 2937 - [`a420004`](https://github.com/jellyfin/jellyfin/commit/a420004f32a88e087b97a0251702e695d458afd3) Merge branch 'fix-sa1694' of https://github.com/bloodsplatter/jellyfin into fix-sa1694 - [`edf0104`](https://github.com/jellyfin/jellyfin/commit/edf01046c567bf8e444d2606db5f78d36363b8ad) Update MediaBrowser.Providers/Plugins/AudioDb/AudioDbAlbumProvider.cs - [`ec9a1dd`](https://github.com/jellyfin/jellyfin/commit/ec9a1dd8ffd95ec68b60450aa2cbec4f2cb41d43) Apply suggestions from code review, again. - [`dfbe86a`](https://github.com/jellyfin/jellyfin/commit/dfbe86acc8fd3c51ba8d7da87c16767d88b36330) Spelling fix in AudioDbOtherAlbumExternalId.cs - [`ee62d6f`](https://github.com/jellyfin/jellyfin/commit/ee62d6fc037d024512ecf2e17edb6884c08f4658) Forgot an xml comment on TvdbEpisodeExternalId - [`e96d36a`](https://github.com/jellyfin/jellyfin/commit/e96d36ad3ebe46c18ccf48ea021c0dff185b5244) Fixing spelling mistakes and adopting wording suggestions - [`cea21f7`](https://github.com/jellyfin/jellyfin/commit/cea21f78ee0622fedc5a2a3f0a7c20a23277bd35) Adding more documentation to extracted classes ### 📊 Changes **43 files changed** (+476 additions, -272 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/Api/DlnaServerService.cs` (+2 -0) 📝 `Emby.Dlna/Api/DlnaService.cs` (+2 -0) 📝 `Emby.Server.Implementations/Library/Resolvers/GenericVideoResolver{T}.cs` (+0 -0) 📝 `Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunManager.cs` (+1 -0) 📝 `Emby.Server.Implementations/Playlists/PlaylistsFolder.cs` (+0 -0) 📝 `Emby.Server.Implementations/Services/RestPath.cs` (+2 -0) 📝 `Emby.Server.Implementations/Services/ServiceExec.cs` (+2 -0) 📝 `Emby.Server.Implementations/Services/SwaggerService.cs` (+2 -0) 📝 `Emby.Server.Implementations/UserViews/FolderImageProvider.cs` (+2 -0) ➕ `MediaBrowser.Controller/Collections/CollectionCreatedEventArgs.cs` (+22 -0) 📝 `MediaBrowser.Controller/Collections/CollectionModifiedEventArgs.cs` (+0 -14) 📝 `MediaBrowser.Controller/Entities/Share.cs` (+6 -5) 📝 `MediaBrowser.Controller/Resolvers/ItemResolver.cs` (+0 -0) 📝 `MediaBrowser.Providers/LiveTv/LiveTvMetadataService.cs` (+0 -0) 📝 `MediaBrowser.Providers/Movies/ImdbExternalId.cs` (+1 -16) ➕ `MediaBrowser.Providers/Movies/ImdbPersonExternalId.cs` (+24 -0) 📝 `MediaBrowser.Providers/Movies/MovieMetadataService.cs` (+13 -0) 📝 `MediaBrowser.Providers/Music/ImvdbId.cs` (+0 -0) ➕ `MediaBrowser.Providers/Plugins/AudioDb/AudioDbAlbumExternalId.cs` (+24 -0) 📝 `MediaBrowser.Providers/Plugins/AudioDb/AudioDbAlbumImageProvider.cs` (+9 -0) _...and 23 more files_ </details> ### 📄 Description By pragma or renaming files. In the Emby.Dlna namespace I've left the Route/Api definitions in their files with the service, since moving these outside of those files creates an ambiguity problem that can't be fixed without adding a namespace or actually changing symbol names. **Changes** Warnings in Emby.Server.Implementations have been silenced by a `#pragma` at the top of the file. In other namespaces this is fixed by moving classes out to their separate files or renaming files. No symbol changes were made. In some files, this created unused using statements, which have been cleaned up. **Issues** Helps with #2149 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 05:59:26 +03:00

OVERLORD closed this issue

2026-02-07 05:59:30 +03:00

OVERLORD referenced this issue

2026-02-07 06:48:23 +03:00

[PR #9160] Backport #9130 #12006

OVERLORD referenced this issue

2026-02-07 06:49:08 +03:00

[PR #9282] refactor: simplify authz #12051

Sign in to join this conversation.