[PR #2913] [CLOSED] BrandingService to ASP.NET WebAPI Migration #9268

New Issue

OVERLORD · 2026-02-07T05:59:11+03:00

OVERLORD commented

2026-02-07 05:59:11 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/2913
Author: @fruhnow
Created: 4/18/2020
Status: ❌ Closed

Base: api-migration ← Head: BrandingServiceWebApiMigration

📝 Commits (10+)

01ce560 Merge branch 'master' into userdb-efcore
7c82346 Fix merge conflicts with SyncPlay
46a0a2a Update migrations and fix a few bugs
fefb282 Fixed issue when LastLoginDate or LastActivityDate were null
eef7cfd Make SonarCloud less angry
31f725f Fix a bug in Emby.Notifications and clean up
73d123f fix issue with audio transcoding
ecadde1 Merge pull request #3192 from jellyfin/audio
6c9dc04 Handle errors during blurhash generation so it does not fail the scan
2482bcb Add blurhashes to ImageBlurHashes for all images

📊 Changes

1249 files changed (+27167 additions, -13666 deletions)

View changed files

📝 .ci/azure-pipelines-abi.yml (+21 -28)
📝 .ci/azure-pipelines-main.yml (+42 -49)
📝 .ci/azure-pipelines-test.yml (+46 -18)
📝 .ci/azure-pipelines.yml (+12 -12)
➖ .copr/Makefile (+0 -59)
➕ .copr/Makefile (+1 -0)
📝 .editorconfig (+7 -10)
➕ .github/CODEOWNERS (+3 -0)
➕ .github/dependabot.yml (+9 -0)
📝 .gitignore (+12 -7)
📝 .vscode/tasks.json (+11 -1)
📝 CONTRIBUTORS.md (+2 -0)
📝 Dockerfile (+1 -1)
📝 Dockerfile.arm (+1 -1)
📝 DvdLib/BigEndianBinaryReader.cs (+2 -0)
📝 DvdLib/DvdLib.csproj (+6 -0)
📝 DvdLib/Ifo/Cell.cs (+3 -0)
📝 DvdLib/Ifo/CellPlaybackInfo.cs (+2 -0)
📝 DvdLib/Ifo/CellPositionInfo.cs (+2 -0)
📝 DvdLib/Ifo/Chapter.cs (+4 -0)

...and 80 more files

📄 Description

Changes
Migrated the BrandingService.cs from MediaBrowser.Api to Jellyfin.Api which is using ASP.NET WebAPI. I wasnt sure if i should delete BrandingService.cs from MediaBrowser.Api so i left it in in the first place.

Issues
Part of #2872

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/2913 **Author:** [@fruhnow](https://github.com/fruhnow) **Created:** 4/18/2020 **Status:** ❌ Closed **Base:** `api-migration` ← **Head:** `BrandingServiceWebApiMigration` --- ### 📝 Commits (10+) - [`01ce560`](https://github.com/jellyfin/jellyfin/commit/01ce56016a3e7189cf29b22b095dc15b82a19303) Merge branch 'master' into userdb-efcore - [`7c82346`](https://github.com/jellyfin/jellyfin/commit/7c823464bca70570f2f53f8af6913e53d385b784) Fix merge conflicts with SyncPlay - [`46a0a2a`](https://github.com/jellyfin/jellyfin/commit/46a0a2a6011bbeaf92af45f9478dda8608ab2c6a) Update migrations and fix a few bugs - [`fefb282`](https://github.com/jellyfin/jellyfin/commit/fefb282137e58529bef35631a9409c8f7f9d7e28) Fixed issue when LastLoginDate or LastActivityDate were null - [`eef7cfd`](https://github.com/jellyfin/jellyfin/commit/eef7cfd91251ee14717dbccfae7505e444048548) Make SonarCloud less angry - [`31f725f`](https://github.com/jellyfin/jellyfin/commit/31f725fdbf9f4a5d91c60cde4dfe8997022f8257) Fix a bug in Emby.Notifications and clean up - [`73d123f`](https://github.com/jellyfin/jellyfin/commit/73d123fe3630a39339cdecef620ee190318ccf88) fix issue with audio transcoding - [`ecadde1`](https://github.com/jellyfin/jellyfin/commit/ecadde1e184b67f95767471baa1a2d25962e1a31) Merge pull request #3192 from jellyfin/audio - [`6c9dc04`](https://github.com/jellyfin/jellyfin/commit/6c9dc0418961a673f9e5dcfb36f66d076381a92e) Handle errors during blurhash generation so it does not fail the scan - [`2482bcb`](https://github.com/jellyfin/jellyfin/commit/2482bcb3b1ba9ea6e861709704ce1f184fcc0d9c) Add blurhashes to ImageBlurHashes for all images ### 📊 Changes **1249 files changed** (+27167 additions, -13666 deletions) <details> <summary>View changed files</summary> 📝 `.ci/azure-pipelines-abi.yml` (+21 -28) 📝 `.ci/azure-pipelines-main.yml` (+42 -49) 📝 `.ci/azure-pipelines-test.yml` (+46 -18) 📝 `.ci/azure-pipelines.yml` (+12 -12) ➖ `.copr/Makefile` (+0 -59) ➕ `.copr/Makefile` (+1 -0) 📝 `.editorconfig` (+7 -10) ➕ `.github/CODEOWNERS` (+3 -0) ➕ `.github/dependabot.yml` (+9 -0) 📝 `.gitignore` (+12 -7) 📝 `.vscode/tasks.json` (+11 -1) 📝 `CONTRIBUTORS.md` (+2 -0) 📝 `Dockerfile` (+1 -1) 📝 `Dockerfile.arm` (+1 -1) 📝 `DvdLib/BigEndianBinaryReader.cs` (+2 -0) 📝 `DvdLib/DvdLib.csproj` (+6 -0) 📝 `DvdLib/Ifo/Cell.cs` (+3 -0) 📝 `DvdLib/Ifo/CellPlaybackInfo.cs` (+2 -0) 📝 `DvdLib/Ifo/CellPositionInfo.cs` (+2 -0) 📝 `DvdLib/Ifo/Chapter.cs` (+4 -0) _...and 80 more files_ </details> ### 📄 Description **Changes** Migrated the BrandingService.cs from ```MediaBrowser.Api``` to ```Jellyfin.Api``` which is using ASP.NET WebAPI. I wasnt sure if i should delete ```BrandingService.cs``` from ```MediaBrowser.Api``` so i left it in in the first place. **Issues** Part of #2872 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 05:59:11 +03:00

OVERLORD closed this issue

2026-02-07 05:59:13 +03:00

OVERLORD referenced this issue

2026-02-07 06:49:02 +03:00

[PR #9268] chore(deps): update github/codeql-action digest to 39d8d7e #12045

Sign in to join this conversation.

Branches Tags

master

release-10.11.z

renovate/skiasharp-monorepo

JPVenson-patch-1

renovate/morestachio-5.x

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#9268