[PR #2798] [MERGED] Make localhost LiveTV restreams always use plain HTTP port #9228

Closed
opened 2026-02-07 05:58:26 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/2798
Author: @JustAMan
Created: 4/7/2020
Status: Merged
Merged: 4/26/2020
Merged by: @joshuaboniface

Base: masterHead: fix-livetv-again


📝 Commits (8)

  • e85f9f5 Make localhost LiveTV restreams always use plain HTTP port
  • 626d4da Make sure Jellyfin listens on localhost no matter what
  • 7a550d2 Apply style change
  • d92a355 Apply style change
  • 0157326 Apply style change
  • 23c8ecf Apply style change
  • 6ac7237 Apply style change
  • cbeeece Apply style change

📊 Changes

6 files changed (+27 additions, -16 deletions)

View changed files

📝 Emby.Server.Implementations/ApplicationHost.cs (+9 -8)
📝 Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs (+1 -1)
📝 Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunUdpStream.cs (+1 -1)
📝 Emby.Server.Implementations/LiveTv/TunerHosts/SharedHttpStream.cs (+1 -1)
📝 Jellyfin.Server/Program.cs (+8 -2)
📝 MediaBrowser.Controller/IServerApplicationHost.cs (+7 -3)

📄 Description

Changes

This is a follow up for https://github.com/jellyfin/jellyfin/pull/2740. This change makes LiveTV restream be accessed by ffmpeg via plain HTTP regardless of secure mode settings. Without the change, when secure mode is set to "Handled by reverse proxy" and neither reverse proxy is running on same host where Jellyfin runs nor Jellyfin having a certificate set it would still fail.

Also I've made Jellyfin to always listen on localhost so LiveTV which needs this connection works regardless of what addresses Jellyfin is told to listen in settings.

Note that due to changing the API this would probably break plugins, so I'm not sure if it's eligible for backporting to 10.5.z releases. Maybe someone from @jellyfin/backend can tell.

Issues

Hopefully fixes https://github.com/jellyfin/jellyfin/issues/2259
Also might help address (now stale) https://github.com/jellyfin/jellyfin/issues/1391, as at least some reports there said LiveTV broke for them when they told Jellyfin to bind selective addresses.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/2798 **Author:** [@JustAMan](https://github.com/JustAMan) **Created:** 4/7/2020 **Status:** ✅ Merged **Merged:** 4/26/2020 **Merged by:** [@joshuaboniface](https://github.com/joshuaboniface) **Base:** `master` ← **Head:** `fix-livetv-again` --- ### 📝 Commits (8) - [`e85f9f5`](https://github.com/jellyfin/jellyfin/commit/e85f9f5613c009a47c9b59ac59cd5930fc45d96a) Make localhost LiveTV restreams always use plain HTTP port - [`626d4da`](https://github.com/jellyfin/jellyfin/commit/626d4dab1062050cca8b4755c79da498f4fed0b7) Make sure Jellyfin listens on localhost no matter what - [`7a550d2`](https://github.com/jellyfin/jellyfin/commit/7a550d2c4efaedc6870f0486f45477808db43c16) Apply style change - [`d92a355`](https://github.com/jellyfin/jellyfin/commit/d92a3552b7add0e0c2010fe380cd29e0bac7cb26) Apply style change - [`0157326`](https://github.com/jellyfin/jellyfin/commit/015732635455c7ddd0e2b5fea28180424c4d56f3) Apply style change - [`23c8ecf`](https://github.com/jellyfin/jellyfin/commit/23c8ecff37636c3705eb5b3cf50b238c6e55e7c1) Apply style change - [`6ac7237`](https://github.com/jellyfin/jellyfin/commit/6ac723706c37200e922d07657300441567574740) Apply style change - [`cbeeece`](https://github.com/jellyfin/jellyfin/commit/cbeeeced759de0452d75b3d6daa11bb213ff2a26) Apply style change ### 📊 Changes **6 files changed** (+27 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+9 -8) 📝 `Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs` (+1 -1) 📝 `Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunUdpStream.cs` (+1 -1) 📝 `Emby.Server.Implementations/LiveTv/TunerHosts/SharedHttpStream.cs` (+1 -1) 📝 `Jellyfin.Server/Program.cs` (+8 -2) 📝 `MediaBrowser.Controller/IServerApplicationHost.cs` (+7 -3) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> This is a follow up for https://github.com/jellyfin/jellyfin/pull/2740. This change makes LiveTV restream be accessed by ffmpeg via plain HTTP regardless of secure mode settings. Without the change, when secure mode is set to "Handled by reverse proxy" and neither reverse proxy is running on same host where Jellyfin runs nor Jellyfin having a certificate set it would still fail. Also I've made Jellyfin to always listen on `localhost` so LiveTV which needs this connection works regardless of what addresses Jellyfin is told to listen in settings. Note that due to changing the API this would probably break plugins, so I'm not sure if it's eligible for backporting to 10.5.z releases. Maybe someone from @jellyfin/backend can tell. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Hopefully fixes https://github.com/jellyfin/jellyfin/issues/2259 Also might help address (now stale) https://github.com/jellyfin/jellyfin/issues/1391, as at least some reports there said LiveTV broke for them when they told Jellyfin to bind selective addresses. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 05:58:26 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9228