mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
[PR #2798] [MERGED] Make localhost LiveTV restreams always use plain HTTP port #9228
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/2798
Author: @JustAMan
Created: 4/7/2020
Status: ✅ Merged
Merged: 4/26/2020
Merged by: @joshuaboniface
Base:
master← Head:fix-livetv-again📝 Commits (8)
e85f9f5Make localhost LiveTV restreams always use plain HTTP port626d4daMake sure Jellyfin listens on localhost no matter what7a550d2Apply style changed92a355Apply style change0157326Apply style change23c8ecfApply style change6ac7237Apply style changecbeeeceApply style change📊 Changes
6 files changed (+27 additions, -16 deletions)
View changed files
📝
Emby.Server.Implementations/ApplicationHost.cs(+9 -8)📝
Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs(+1 -1)📝
Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunUdpStream.cs(+1 -1)📝
Emby.Server.Implementations/LiveTv/TunerHosts/SharedHttpStream.cs(+1 -1)📝
Jellyfin.Server/Program.cs(+8 -2)📝
MediaBrowser.Controller/IServerApplicationHost.cs(+7 -3)📄 Description
Changes
This is a follow up for https://github.com/jellyfin/jellyfin/pull/2740. This change makes LiveTV restream be accessed by ffmpeg via plain HTTP regardless of secure mode settings. Without the change, when secure mode is set to "Handled by reverse proxy" and neither reverse proxy is running on same host where Jellyfin runs nor Jellyfin having a certificate set it would still fail.
Also I've made Jellyfin to always listen on
localhostso LiveTV which needs this connection works regardless of what addresses Jellyfin is told to listen in settings.Note that due to changing the API this would probably break plugins, so I'm not sure if it's eligible for backporting to 10.5.z releases. Maybe someone from @jellyfin/backend can tell.
Issues
Hopefully fixes https://github.com/jellyfin/jellyfin/issues/2259
Also might help address (now stale) https://github.com/jellyfin/jellyfin/issues/1391, as at least some reports there said LiveTV broke for them when they told Jellyfin to bind selective addresses.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.