starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #2674] [MERGED] Make variables binding correspond with column names #9185

New Issue
Closed
opened 2026-02-07 05:57:43 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 05:57:43 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/2674
Author: @JustAMan
Created: 3/26/2020
Status: ✅ Merged
Merged: 3/26/2020
Merged by: @Bond-009

Base: master ← Head: fix-attachments-scan

📝 Commits (1)

  • 0d2a355 Make variables binding correspond with column names

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 Emby.Server.Implementations/Data/SqliteItemRepository.cs (+2 -2)

📄 Description

Changes
When building a SQL statement, variables being bound must correspond to placeholder names.
The insert query was using _mediaAttachmentSaveColumns for names, so I'm fixing bindings to use same names.

Issues

Without this patch saving scanned attachments for me are completely broken erroring out with

[ERR] [22] App: Error in ffprobe
System.ArgumentException: Invalid param name: @FileName0 (Parameter 'name')
   at Emby.Server.Implementations.Data.SqliteExtensions.CheckName(String name) in jf-src\jellyfin\Emby.Server.Implementations\Data\SqliteExtensions.cs:line 184
   at Emby.Server.Implementations.Data.SqliteExtensions.TryBind(IStatement statement, String name, String value) in jf-src\jellyfin\Emby.Server.Implementations\Data\SqliteExtensions.cs:line 215
   at Emby.Server.Implementations.Data.SqliteItemRepository.InsertMediaAttachments(Byte[] idBlob, IReadOnlyList`1 attachments, IDatabaseConnection db, CancellationToken cancellationToken) in jf-src\jellyfin\Emby.Server.Implementations\Data\SqliteItemRepository.cs:line 6291
   at Emby.Server.Implementations.Data.SqliteItemRepository.<>c__DisplayClass127_0.<SaveMediaAttachments>b__0(IDatabaseConnection db) in jf-src\jellyfin\Emby.Server.Implementations\Data\SqliteItemRepository.cs:line 6238
   at SQLitePCL.pretty.DatabaseConnection.<>c__DisplayClass20_0.<RunInTransaction>b__0(IDatabaseConnection db)
   at SQLitePCL.pretty.DatabaseConnection.RunInTransaction[T](IDatabaseConnection This, Func`2 f, TransactionMode mode)
   at SQLitePCL.pretty.DatabaseConnection.RunInTransaction(IDatabaseConnection This, Action`1 action, TransactionMode mode)
   at Emby.Server.Implementations.Data.ManagedConnection.RunInTransaction(Action`1 action, TransactionMode mode) in jf-src\jellyfin\Emby.Server.Implementations\Data\ManagedConnection.cs:line 50
   at Emby.Server.Implementations.Data.SqliteItemRepository.SaveMediaAttachments(Guid id, IReadOnlyList`1 attachments, CancellationToken cancellationToken) in jf-src\jellyfin\Emby.Server.Implementations\Data\SqliteItemRepository.cs:line 6232
   at MediaBrowser.Providers.MediaInfo.FFProbeVideoInfo.Fetch(Video video, CancellationToken cancellationToken, MediaInfo mediaInfo, BlurayDiscInfo blurayInfo, MetadataRefreshOptions options) in jf-src\jellyfin\MediaBrowser.Providers\MediaInfo\FFProbeVideoInfo.cs:line 229
   at MediaBrowser.Providers.MediaInfo.FFProbeVideoInfo.ProbeVideo[T](T item, MetadataRefreshOptions options, CancellationToken cancellationToken) in jf-src\jellyfin\MediaBrowser.Providers\MediaInfo\FFProbeVideoInfo.cs:line 119
   at MediaBrowser.Providers.Manager.MetadataService`2.RunCustomProvider(ICustomMetadataProvider`1 provider, TItemType item, String logName, MetadataRefreshOptions options, RefreshResult refreshResult, CancellationToken cancellationToken) in jf-src\jellyfin\MediaBrowser.Providers\Manager\MetadataService.cs:line 804

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/2674 **Author:** [@JustAMan](https://github.com/JustAMan) **Created:** 3/26/2020 **Status:** ✅ Merged **Merged:** 3/26/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `fix-attachments-scan` --- ### 📝 Commits (1) - [`0d2a355`](https://github.com/jellyfin/jellyfin/commit/0d2a355c00f9309631953af675aeb8e47b32575e) Make variables binding correspond with column names ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Data/SqliteItemRepository.cs` (+2 -2) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** When building a SQL statement, variables being bound must correspond to placeholder names. The insert query was using `_mediaAttachmentSaveColumns` for names, so I'm fixing bindings to use same names. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Without this patch saving scanned attachments for me are completely broken erroring out with ``` [ERR] [22] App: Error in ffprobe System.ArgumentException: Invalid param name: @FileName0 (Parameter 'name') at Emby.Server.Implementations.Data.SqliteExtensions.CheckName(String name) in jf-src\jellyfin\Emby.Server.Implementations\Data\SqliteExtensions.cs:line 184 at Emby.Server.Implementations.Data.SqliteExtensions.TryBind(IStatement statement, String name, String value) in jf-src\jellyfin\Emby.Server.Implementations\Data\SqliteExtensions.cs:line 215 at Emby.Server.Implementations.Data.SqliteItemRepository.InsertMediaAttachments(Byte[] idBlob, IReadOnlyList`1 attachments, IDatabaseConnection db, CancellationToken cancellationToken) in jf-src\jellyfin\Emby.Server.Implementations\Data\SqliteItemRepository.cs:line 6291 at Emby.Server.Implementations.Data.SqliteItemRepository.<>c__DisplayClass127_0.<SaveMediaAttachments>b__0(IDatabaseConnection db) in jf-src\jellyfin\Emby.Server.Implementations\Data\SqliteItemRepository.cs:line 6238 at SQLitePCL.pretty.DatabaseConnection.<>c__DisplayClass20_0.<RunInTransaction>b__0(IDatabaseConnection db) at SQLitePCL.pretty.DatabaseConnection.RunInTransaction[T](IDatabaseConnection This, Func`2 f, TransactionMode mode) at SQLitePCL.pretty.DatabaseConnection.RunInTransaction(IDatabaseConnection This, Action`1 action, TransactionMode mode) at Emby.Server.Implementations.Data.ManagedConnection.RunInTransaction(Action`1 action, TransactionMode mode) in jf-src\jellyfin\Emby.Server.Implementations\Data\ManagedConnection.cs:line 50 at Emby.Server.Implementations.Data.SqliteItemRepository.SaveMediaAttachments(Guid id, IReadOnlyList`1 attachments, CancellationToken cancellationToken) in jf-src\jellyfin\Emby.Server.Implementations\Data\SqliteItemRepository.cs:line 6232 at MediaBrowser.Providers.MediaInfo.FFProbeVideoInfo.Fetch(Video video, CancellationToken cancellationToken, MediaInfo mediaInfo, BlurayDiscInfo blurayInfo, MetadataRefreshOptions options) in jf-src\jellyfin\MediaBrowser.Providers\MediaInfo\FFProbeVideoInfo.cs:line 229 at MediaBrowser.Providers.MediaInfo.FFProbeVideoInfo.ProbeVideo[T](T item, MetadataRefreshOptions options, CancellationToken cancellationToken) in jf-src\jellyfin\MediaBrowser.Providers\MediaInfo\FFProbeVideoInfo.cs:line 119 at MediaBrowser.Providers.Manager.MetadataService`2.RunCustomProvider(ICustomMetadataProvider`1 provider, TItemType item, String logName, MetadataRefreshOptions options, RefreshResult refreshResult, CancellationToken cancellationToken) in jf-src\jellyfin\MediaBrowser.Providers\Manager\MetadataService.cs:line 804 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 05:57:43 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9185
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?