[PR #2636] [MERGED] Use ASP.NET Core HTTPS Development Certificate #9170

Closed
opened 2026-02-07 05:57:26 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/2636
Author: @mark-monteiro
Created: 3/22/2020
Status: Merged
Merged: 4/5/2020
Merged by: @Bond-009

Base: masterHead: development-https


📝 Commits (6)

  • edc974e Set 'ASPNETCORE_ENVIRONMENT=Development' when running from visual studio
  • 54cbf9c Bind HTTPS ports when running with development environment flag
  • 0e3d319 Log 'ASPNETCORE_ENVIRONMENT' value at application startup
  • c36e4ec Log all 'DOTNET_' and 'ASPNETCORE_' environment variables at application startup
  • 0e57348 Merge remote-tracking branch 'upstream/master' into development-https
  • bc91445 Use correct naming convention for _relevantEnvVarPrefixes

📊 Changes

3 files changed (+37 additions, -8 deletions)

View changed files

📝 Emby.Server.Implementations/ApplicationHost.cs (+10 -5)
📝 Jellyfin.Server/Program.cs (+19 -1)
📝 Jellyfin.Server/Properties/launchSettings.json (+8 -2)

📄 Description

The .NET Core SDK includes an HTTPS development certificate that is is installed as part of the first-run experience (docs). When running in development mode we can serve over HTTPS using this certificate.

Changes

  • Set ASPNETCORE_ENVIRONMENT=Development environment variable when running from Visual Studio, VS Code, or dotnet run CLI (docs)
  • At application startup, if we are in development mode, bind HTTPS ports using the SDK development certificate. If a custom certificate is configured, that is still given priority over this built-in one
  • Log the values for all DOTNET_ and ASPNETCORE_ prefixed environment variables at server start (this includes ASPNETCORE_ENVIRONMENT) (docs)

I've also added documentation about this to the project README in #2620


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/2636 **Author:** [@mark-monteiro](https://github.com/mark-monteiro) **Created:** 3/22/2020 **Status:** ✅ Merged **Merged:** 4/5/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `development-https` --- ### 📝 Commits (6) - [`edc974e`](https://github.com/jellyfin/jellyfin/commit/edc974e4c01649ab6e0286f617c6b371a8735391) Set 'ASPNETCORE_ENVIRONMENT=Development' when running from visual studio - [`54cbf9c`](https://github.com/jellyfin/jellyfin/commit/54cbf9c4dc819095e067b1ffe7c2199147ad2ebb) Bind HTTPS ports when running with development environment flag - [`0e3d319`](https://github.com/jellyfin/jellyfin/commit/0e3d319a3aea3a3b951f0b058ce9f2d0e0c52a11) Log 'ASPNETCORE_ENVIRONMENT' value at application startup - [`c36e4ec`](https://github.com/jellyfin/jellyfin/commit/c36e4ecc6c632abffb4c72cd07023449362c9cb3) Log all 'DOTNET_' and 'ASPNETCORE_' environment variables at application startup - [`0e57348`](https://github.com/jellyfin/jellyfin/commit/0e57348cf45316c0d318adba3ef5e9d61bbfdf74) Merge remote-tracking branch 'upstream/master' into development-https - [`bc91445`](https://github.com/jellyfin/jellyfin/commit/bc91445b5dab26713c7b66629518504d5e4b5168) Use correct naming convention for _relevantEnvVarPrefixes ### 📊 Changes **3 files changed** (+37 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+10 -5) 📝 `Jellyfin.Server/Program.cs` (+19 -1) 📝 `Jellyfin.Server/Properties/launchSettings.json` (+8 -2) </details> ### 📄 Description The .NET Core SDK includes an HTTPS development certificate that is is installed as part of the first-run experience ([docs](https://docs.microsoft.com/en-us/aspnet/core/security/enforcing-ssl?view=aspnetcore-3.1&tabs=visual-studio#trust-the-aspnet-core-https-development-certificate-on-windows-and-macos)). When running in development mode we can serve over HTTPS using this certificate. **Changes** * Set `ASPNETCORE_ENVIRONMENT=Development` environment variable when running from Visual Studio, VS Code, or `dotnet run` CLI ([docs](https://docs.microsoft.com/en-us/aspnet/core/fundamentals/environments?view=aspnetcore-3.1#development)) * At application startup, if we are in development mode, bind HTTPS ports using the SDK development certificate. If a custom certificate is configured, that is still given priority over this built-in one * Log the values for all `DOTNET_` and `ASPNETCORE_` prefixed environment variables at server start (this includes `ASPNETCORE_ENVIRONMENT`) ([docs](https://docs.microsoft.com/en-us/aspnet/core/fundamentals/host/generic-host?view=aspnetcore-3.1#host-configuration)) I've also added documentation about this to the project README in #2620 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 05:57:26 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9170