starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #1871] [MERGED] Enable TreatWarningsAsErrors for MediaBrowser.Common and Emby.Photos #8935

New Issue
Closed
opened 2026-02-07 05:53:03 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 05:53:03 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/1871
Author: @Bond-009
Created: 10/9/2019
Status: ✅ Merged
Merged: 10/16/2019
Merged by: @JustAMan

Base: master ← Head: doc

📝 Commits (1)

  • 9d4ce82 Enable TreatWarningsAsErrors for MediaBrowser.Common and Emby.Photos

📊 Changes

28 files changed (+99 additions, -37 deletions)

View changed files

📝 Emby.Photos/Emby.Photos.csproj (+12 -0)
📝 Emby.Photos/PhotoProvider.cs (+17 -13)
📝 Emby.Server.Implementations/AppBase/BaseApplicationPaths.cs (+1 -4)
📝 Emby.Server.Implementations/ApplicationHost.cs (+5 -2)
📝 MediaBrowser.Common/Configuration/ConfigurationUpdateEventArgs.cs (+3 -0)
📝 MediaBrowser.Common/Configuration/IApplicationPaths.cs (+4 -1)
📝 MediaBrowser.Common/Configuration/IConfigurationFactory.cs (+2 -0)
📝 MediaBrowser.Common/Configuration/IConfigurationManager.cs (+2 -0)
📝 MediaBrowser.Common/Cryptography/PasswordHash.cs (+2 -0)
📝 MediaBrowser.Common/Events/EventHelper.cs (+2 -0)
📝 MediaBrowser.Common/Extensions/CollectionExtensions.cs (+2 -0)
📝 MediaBrowser.Common/Extensions/ResourceNotFoundException.cs (+2 -0)
📝 MediaBrowser.Common/HexHelper.cs (+2 -0)
📝 MediaBrowser.Common/IApplicationHost.cs (+10 -3)
📝 MediaBrowser.Common/MediaBrowser.Common.csproj (+1 -0)
📝 MediaBrowser.Common/Net/CustomHeaderNames.cs (+2 -0)
📝 MediaBrowser.Common/Net/HttpRequestOptions.cs (+2 -0)
📝 MediaBrowser.Common/Net/HttpResponseInfo.cs (+3 -0)
📝 MediaBrowser.Common/Net/IHttpClient.cs (+3 -1)
📝 MediaBrowser.Common/Net/INetworkManager.cs (+2 -0)

...and 8 more files

📄 Description

Adds #pragma warning disable CS1591 to all files in
MediaBrowser.Common containing undocumented members.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/1871 **Author:** [@Bond-009](https://github.com/Bond-009) **Created:** 10/9/2019 **Status:** ✅ Merged **Merged:** 10/16/2019 **Merged by:** [@JustAMan](https://github.com/JustAMan) **Base:** `master` ← **Head:** `doc` --- ### 📝 Commits (1) - [`9d4ce82`](https://github.com/jellyfin/jellyfin/commit/9d4ce82ab9e85a89aa2463e051f805113d952ac5) Enable `TreatWarningsAsErrors` for MediaBrowser.Common and Emby.Photos ### 📊 Changes **28 files changed** (+99 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Photos/Emby.Photos.csproj` (+12 -0) 📝 `Emby.Photos/PhotoProvider.cs` (+17 -13) 📝 `Emby.Server.Implementations/AppBase/BaseApplicationPaths.cs` (+1 -4) 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+5 -2) 📝 `MediaBrowser.Common/Configuration/ConfigurationUpdateEventArgs.cs` (+3 -0) 📝 `MediaBrowser.Common/Configuration/IApplicationPaths.cs` (+4 -1) 📝 `MediaBrowser.Common/Configuration/IConfigurationFactory.cs` (+2 -0) 📝 `MediaBrowser.Common/Configuration/IConfigurationManager.cs` (+2 -0) 📝 `MediaBrowser.Common/Cryptography/PasswordHash.cs` (+2 -0) 📝 `MediaBrowser.Common/Events/EventHelper.cs` (+2 -0) 📝 `MediaBrowser.Common/Extensions/CollectionExtensions.cs` (+2 -0) 📝 `MediaBrowser.Common/Extensions/ResourceNotFoundException.cs` (+2 -0) 📝 `MediaBrowser.Common/HexHelper.cs` (+2 -0) 📝 `MediaBrowser.Common/IApplicationHost.cs` (+10 -3) 📝 `MediaBrowser.Common/MediaBrowser.Common.csproj` (+1 -0) 📝 `MediaBrowser.Common/Net/CustomHeaderNames.cs` (+2 -0) 📝 `MediaBrowser.Common/Net/HttpRequestOptions.cs` (+2 -0) 📝 `MediaBrowser.Common/Net/HttpResponseInfo.cs` (+3 -0) 📝 `MediaBrowser.Common/Net/IHttpClient.cs` (+3 -1) 📝 `MediaBrowser.Common/Net/INetworkManager.cs` (+2 -0) _...and 8 more files_ </details> ### 📄 Description Adds `#pragma warning disable CS1591` to all files in MediaBrowser.Common containing undocumented members. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 05:53:03 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#8935
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?