mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
[PR #1863] [MERGED] Fix inconsistent BaseUrl behavior #8927
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/1863
Author: @joshuaboniface
Created: 10/8/2019
Status: ✅ Merged
Merged: 10/9/2019
Merged by: @JustAMan
Base:
master← Head:fix-baseurl-issues📝 Commits (4)
2a79ae0Normalize baseUrl behaviourb96079fMake NormalizeUrlPath staticb10e06fFix spacing issues345a14fUse value instead of assigning baseUrl first📊 Changes
2 files changed (+63 additions, -41 deletions)
View changed files
📝
Emby.Server.Implementations/HttpServer/HttpListenerHost.cs(+34 -39)📝
MediaBrowser.Model/Configuration/ServerConfiguration.cs(+29 -2)📄 Description
Changes
Fixes the inconsistent BaseUrl behaviour to better match standard behaviour for this sort of feature. This will now always append a configured BaseUrl to the default redirects, which should then work for all other URLs as well. Also includes a normalization of the static URLs (
/embyand/mediabrowser) with the BaseUrl, such that the expected path scheme will continue to work.To complement this, the default BaseUrl is now set to an empty string rather than
jellyfin.Issues
Fixes #1851
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.