[PR #1863] [MERGED] Fix inconsistent BaseUrl behavior #8927

Closed
opened 2026-02-07 05:52:56 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/1863
Author: @joshuaboniface
Created: 10/8/2019
Status: Merged
Merged: 10/9/2019
Merged by: @JustAMan

Base: masterHead: fix-baseurl-issues


📝 Commits (4)

  • 2a79ae0 Normalize baseUrl behaviour
  • b96079f Make NormalizeUrlPath static
  • b10e06f Fix spacing issues
  • 345a14f Use value instead of assigning baseUrl first

📊 Changes

2 files changed (+63 additions, -41 deletions)

View changed files

📝 Emby.Server.Implementations/HttpServer/HttpListenerHost.cs (+34 -39)
📝 MediaBrowser.Model/Configuration/ServerConfiguration.cs (+29 -2)

📄 Description

Changes
Fixes the inconsistent BaseUrl behaviour to better match standard behaviour for this sort of feature. This will now always append a configured BaseUrl to the default redirects, which should then work for all other URLs as well. Also includes a normalization of the static URLs (/emby and /mediabrowser) with the BaseUrl, such that the expected path scheme will continue to work.

To complement this, the default BaseUrl is now set to an empty string rather than jellyfin.

Issues
Fixes #1851


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/1863 **Author:** [@joshuaboniface](https://github.com/joshuaboniface) **Created:** 10/8/2019 **Status:** ✅ Merged **Merged:** 10/9/2019 **Merged by:** [@JustAMan](https://github.com/JustAMan) **Base:** `master` ← **Head:** `fix-baseurl-issues` --- ### 📝 Commits (4) - [`2a79ae0`](https://github.com/jellyfin/jellyfin/commit/2a79ae0a6e4deb4f5d1eb83a377d26ff542c88ca) Normalize baseUrl behaviour - [`b96079f`](https://github.com/jellyfin/jellyfin/commit/b96079fee6c8cf8919eb1f531bdfaac3db3fb2b8) Make NormalizeUrlPath static - [`b10e06f`](https://github.com/jellyfin/jellyfin/commit/b10e06ff459476042cff0eec5ebea3c304e6d1f5) Fix spacing issues - [`345a14f`](https://github.com/jellyfin/jellyfin/commit/345a14ff5543256a4fa5c6a55f76d77334972c67) Use value instead of assigning baseUrl first ### 📊 Changes **2 files changed** (+63 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/HttpServer/HttpListenerHost.cs` (+34 -39) 📝 `MediaBrowser.Model/Configuration/ServerConfiguration.cs` (+29 -2) </details> ### 📄 Description **Changes** Fixes the inconsistent BaseUrl behaviour to better match standard behaviour for this sort of feature. This will now always append a configured BaseUrl to the default redirects, which should then work for all other URLs as well. Also includes a normalization of the static URLs (`/emby` and `/mediabrowser`) with the BaseUrl, such that the expected path scheme will continue to work. To complement this, the default BaseUrl is now set to an empty string rather than `jellyfin`. **Issues** Fixes #1851 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 05:52:56 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#8927