starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #1819] [MERGED] Ignore exception when attempting to kill ffmpeg that has exited #8908

New Issue
Closed
opened 2026-02-07 05:52:35 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 05:52:35 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/1819
Author: @andrewrabert
Created: 9/30/2019
Status: ✅ Merged
Merged: 9/30/2019
Merged by: @joshuaboniface

Base: master ← Head: ffmpeg_kill

📝 Commits (1)

  • fd1bdad Ignore exception when attempting to kill ffmpeg that has exited

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 MediaBrowser.Api/ApiEntryPoint.cs (+1 -2)

📄 Description

Changes
A race condition where this code attempts to kill an already exited
ffmpeg process is possible. This results in unnecessary error logging.

This change replaces the generic exception handling with the above
mentioned exception. No log output is produced. Ignoring this exception seems safe per the docs https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.process.kill?view=netframework-4.8#System_Diagnostics_Process_Kill

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/1819 **Author:** [@andrewrabert](https://github.com/andrewrabert) **Created:** 9/30/2019 **Status:** ✅ Merged **Merged:** 9/30/2019 **Merged by:** [@joshuaboniface](https://github.com/joshuaboniface) **Base:** `master` ← **Head:** `ffmpeg_kill` --- ### 📝 Commits (1) - [`fd1bdad`](https://github.com/jellyfin/jellyfin/commit/fd1bdad0e22715cb589d3bbee9ed9805989ac544) Ignore exception when attempting to kill ffmpeg that has exited ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Api/ApiEntryPoint.cs` (+1 -2) </details> ### 📄 Description **Changes** A race condition where this code attempts to kill an already exited ffmpeg process is possible. This results in unnecessary error logging. This change replaces the generic exception handling with the above mentioned exception. No log output is produced. Ignoring this exception seems safe per the docs https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.process.kill?view=netframework-4.8#System_Diagnostics_Process_Kill --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 05:52:35 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#8908
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?