mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
[PR #1811] [MERGED] Configure Kestrel listener to use configured IPs #8899
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/1811
Author: @joshuaboniface
Created: 9/29/2019
Status: ✅ Merged
Merged: 9/30/2019
Merged by: @joshuaboniface
Base:
master← Head:fix-listen📝 Commits (2)
cabb9aeConfigure Kestrel listener to use configured IPs3871926Handle Kestrel startup failures with a nice error📊 Changes
1 file changed (+35 additions, -4 deletions)
View changed files
📝
Emby.Server.Implementations/ApplicationHost.cs(+35 -4)📄 Description
Changes
Our Kestrel configuration used
ListenAnyIP, probably a testing/initial configuration holdover. This resulted in Kestrel always binding to a wildcard instead of the configured addresses.This PR implements a per-IP listener, based on https://docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/kestrel?view=aspnetcore-3.0#bind-to-a-tcp-socket. It will loop through all configured IPs and listen on all of them, or listen on all interfaces as was the default if no explicit IPs are are specified.
Explicitly works with
0.0.0.0as well to force IPv4-only wildcard binding.Issues
Fixes #1810
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.