starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #1677] [MERGED] Remove legacy auth code #8850

New Issue
Closed
opened 2026-02-07 05:51:27 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 05:51:27 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/1677
Author: @Bond-009
Created: 8/28/2019
Status: ✅ Merged
Merged: 9/17/2019
Merged by: @anthonylavado

Base: master ← Head: test

📝 Commits (5)

📊 Changes

34 files changed (+354 additions, -3430 deletions)

View changed files

📝 Emby.Server.Implementations/Cryptography/CryptographyProvider.cs (+9 -56)
📝 Emby.Server.Implementations/Library/DefaultAuthenticationProvider.cs (+36 -98)
📝 Emby.Server.Implementations/Library/UserManager.cs (+22 -36)
📝 Emby.Server.Implementations/Updates/InstallationManager.cs (+2 -2)
📝 MediaBrowser.Api/StartupWizardService.cs (+2 -1)
➕ MediaBrowser.Common/Cryptography/Constants.cs (+18 -0)
➕ MediaBrowser.Common/Cryptography/Extensions.cs (+35 -0)
➕ MediaBrowser.Common/Cryptography/PasswordHash.cs (+155 -0)
📝 MediaBrowser.Common/HexHelper.cs (+1 -1)
📝 MediaBrowser.Common/MediaBrowser.Common.csproj (+6 -0)
📝 MediaBrowser.Model/Cryptography/ICryptoProvider.cs (+8 -11)
➖ MediaBrowser.Model/Cryptography/PasswordHash.cs (+0 -142)
➖ MediaBrowser.Tests/ConsistencyTests/Resources/SampleTransformed.htm (+0 -1277)
➖ MediaBrowser.Tests/ConsistencyTests/Resources/StringCheck.xslt (+0 -145)
➖ MediaBrowser.Tests/ConsistencyTests/Resources/StringCheckSample.xml (+0 -222)
➖ MediaBrowser.Tests/ConsistencyTests/StringUsageReporter.cs (+0 -259)
➖ MediaBrowser.Tests/ConsistencyTests/TextIndexing/IndexBuilder.cs (+0 -52)
➖ MediaBrowser.Tests/ConsistencyTests/TextIndexing/WordIndex.cs (+0 -36)
➖ MediaBrowser.Tests/ConsistencyTests/TextIndexing/WordOccurrence.cs (+0 -18)
➖ MediaBrowser.Tests/ConsistencyTests/TextIndexing/WordOccurrences.cs (+0 -13)

...and 14 more files

📄 Description

  • Adds tests so we don't break PasswordHash (again)
  • Clean up interfaces
  • Remove duplicate code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/1677 **Author:** [@Bond-009](https://github.com/Bond-009) **Created:** 8/28/2019 **Status:** ✅ Merged **Merged:** 9/17/2019 **Merged by:** [@anthonylavado](https://github.com/anthonylavado) **Base:** `master` ← **Head:** `test` --- ### 📝 Commits (5) - [`64f9002`](https://github.com/jellyfin/jellyfin/commit/64f9002be136b0d972e1b2a03e7e44aad9ff7051) Remove legacy auth code - [`5115863`](https://github.com/jellyfin/jellyfin/commit/51158637c4242ec3eea464377c28f8dc2284f97f) Use auto properties - [`4645224`](https://github.com/jellyfin/jellyfin/commit/46452248e1ad78295a6030a72efe43ad5543f5b7) static using - [`5c88fa6`](https://github.com/jellyfin/jellyfin/commit/5c88fa695d8b7b4ccbe504c67b7db717f305a6cd) Don't use 'this' - [`d17d4a2`](https://github.com/jellyfin/jellyfin/commit/d17d4a24b77cad6dcda08cbf6b772accb2dd59f4) Fix build ### 📊 Changes **34 files changed** (+354 additions, -3430 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Cryptography/CryptographyProvider.cs` (+9 -56) 📝 `Emby.Server.Implementations/Library/DefaultAuthenticationProvider.cs` (+36 -98) 📝 `Emby.Server.Implementations/Library/UserManager.cs` (+22 -36) 📝 `Emby.Server.Implementations/Updates/InstallationManager.cs` (+2 -2) 📝 `MediaBrowser.Api/StartupWizardService.cs` (+2 -1) ➕ `MediaBrowser.Common/Cryptography/Constants.cs` (+18 -0) ➕ `MediaBrowser.Common/Cryptography/Extensions.cs` (+35 -0) ➕ `MediaBrowser.Common/Cryptography/PasswordHash.cs` (+155 -0) 📝 `MediaBrowser.Common/HexHelper.cs` (+1 -1) 📝 `MediaBrowser.Common/MediaBrowser.Common.csproj` (+6 -0) 📝 `MediaBrowser.Model/Cryptography/ICryptoProvider.cs` (+8 -11) ➖ `MediaBrowser.Model/Cryptography/PasswordHash.cs` (+0 -142) ➖ `MediaBrowser.Tests/ConsistencyTests/Resources/SampleTransformed.htm` (+0 -1277) ➖ `MediaBrowser.Tests/ConsistencyTests/Resources/StringCheck.xslt` (+0 -145) ➖ `MediaBrowser.Tests/ConsistencyTests/Resources/StringCheckSample.xml` (+0 -222) ➖ `MediaBrowser.Tests/ConsistencyTests/StringUsageReporter.cs` (+0 -259) ➖ `MediaBrowser.Tests/ConsistencyTests/TextIndexing/IndexBuilder.cs` (+0 -52) ➖ `MediaBrowser.Tests/ConsistencyTests/TextIndexing/WordIndex.cs` (+0 -36) ➖ `MediaBrowser.Tests/ConsistencyTests/TextIndexing/WordOccurrence.cs` (+0 -18) ➖ `MediaBrowser.Tests/ConsistencyTests/TextIndexing/WordOccurrences.cs` (+0 -13) _...and 14 more files_ </details> ### 📄 Description * Adds tests so we don't break `PasswordHash` (again) * Clean up interfaces * Remove duplicate code --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 05:51:27 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#8850
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?